From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12606 invoked by alias); 27 Nov 2014 07:41:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12592 invoked by uid 89); 27 Nov 2014 07:41:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 27 Nov 2014 07:41:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B4AB8116817; Thu, 27 Nov 2014 02:41:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id jr2Rd72a8THe; Thu, 27 Nov 2014 02:41:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 551241164AD; Thu, 27 Nov 2014 02:41:17 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 9871940F79; Thu, 27 Nov 2014 11:41:13 +0400 (RET) Date: Thu, 27 Nov 2014 07:41:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7 V2] Import the rename gnulib module Message-ID: <20141127074113.GB5042@adacore.com> References: <1416980800-21408-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416980800-21408-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00679.txt.bz2 > This patch series is to import rename gnulib module and other > dependent modules. We need rename module to fix some > fileio.exp fails on mingw32 host, on which the errno setting > isn't compliance with POSIX. V1 can be found > https://sourceware.org/ml/gdb-patches/2014-10/msg00837.html > > rename module depends on readlink, lstat and canonicalize-lgpl modules, > and they are used by GDB too, so this patch series imports them > explicitly and use them. Patches 1, 3, and 5 import readlink, > lstat and canonicalize-lgpl respectively. Patches 2, 4, and 6 > are to use these api unconditionally. Patch 7 is about importing > rename module. > > Regression tested on x86_64-linux and arm-eabi both on linux host > ahd mingw32 host. Two fails in fileio.exp on mingw32 host are > fixed. I skimmed through the patch set, and didn't any problem (one question, but not blocking). Thanks for doing this, Yao. I agree it helps making our codebase slightly more straightforward. -- Joel