From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add more missing parentheses to Python calls to print
Date: Thu, 27 Nov 2014 08:32:00 -0000 [thread overview]
Message-ID: <20141127083246.GD5042@adacore.com> (raw)
In-Reply-To: <1417026833-781-1-git-send-email-simon.marchi@ericsson.com>
Hi Simon,
On Wed, Nov 26, 2014 at 01:33:53PM -0500, Simon Marchi wrote:
> I noticed that there are calls to Python's print outside the gdb.python
> directory, so this patch adds those that I found were missing. They were
> found by grepping for "python print [^(]", so it's always possible that
> I missed some others that use another pattern.
>
> Parentheses are mandatory with Python 3 when calling print.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.ada/py_range.exp: Add missing parentheses.
> * gdb.dwarf2/symtab-producer.exp: Same.
> * gdb.gdb/python-interrupts.exp: Same.
> * gdb.gdb/python-selftest.exp: Same.
This is pre-approved, but can you remove the space before
the opening parenthesis? Since "print" has become a function
in Python 3, and we try to follow the standard python style,
unlike our GNU Coding Style in C/C++, there should be no
space before the parenthesis.
Thank you!
--
Joel
prev parent reply other threads:[~2014-11-27 8:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 18:34 Simon Marchi
2014-11-27 8:32 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127083246.GD5042@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).