From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3987 invoked by alias); 27 Nov 2014 08:32:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3976 invoked by uid 89); 27 Nov 2014 08:32:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 27 Nov 2014 08:32:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 3E1D81166D2; Thu, 27 Nov 2014 03:32:50 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id mOtNG3u6DrR6; Thu, 27 Nov 2014 03:32:50 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D2FA2116538; Thu, 27 Nov 2014 03:32:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2619140F79; Thu, 27 Nov 2014 12:32:46 +0400 (RET) Date: Thu, 27 Nov 2014 08:32:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Add more missing parentheses to Python calls to print Message-ID: <20141127083246.GD5042@adacore.com> References: <1417026833-781-1-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1417026833-781-1-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00681.txt.bz2 Hi Simon, On Wed, Nov 26, 2014 at 01:33:53PM -0500, Simon Marchi wrote: > I noticed that there are calls to Python's print outside the gdb.python > directory, so this patch adds those that I found were missing. They were > found by grepping for "python print [^(]", so it's always possible that > I missed some others that use another pattern. > > Parentheses are mandatory with Python 3 when calling print. > > gdb/testsuite/ChangeLog: > > * gdb.ada/py_range.exp: Add missing parentheses. > * gdb.dwarf2/symtab-producer.exp: Same. > * gdb.gdb/python-interrupts.exp: Same. > * gdb.gdb/python-selftest.exp: Same. This is pre-approved, but can you remove the space before the opening parenthesis? Since "print" has become a function in Python 3, and we try to follow the standard python style, unlike our GNU Coding Style in C/C++, there should be no space before the parenthesis. Thank you! -- Joel