From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org, simon.marchi@polymtl.ca
Subject: Re: [PATCH 3/3] Fix prints in tests for Python 3
Date: Thu, 27 Nov 2014 08:40:00 -0000 [thread overview]
Message-ID: <20141127084017.GE5042@adacore.com> (raw)
In-Reply-To: <1416976561-1927-3-git-send-email-simon.marchi@ericsson.com>
> Python 3's print requires to use parentheses, so this patch adds them where
> they were missing.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.python/py-linetable.exp: Add parentheses to calls to print.
> * gdb.python/py-type.exp: Same.
> * gdb.python/py-value-cc.exp: Same.
> * gdb.python/py-value.exp: Same.
Pre-approved with the same comment as before: Can you remove the space
between "print" and "(", please? You can push any other changes of this
nature under the "obvious" rule.
Thank you!
--
Joel
next prev parent reply other threads:[~2014-11-27 8:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 4:36 [PATCH 1/3] python extended prompt: Use os.getcwd() instead of os.getcwdu() Simon Marchi
2014-11-26 4:36 ` [PATCH 3/3] Fix prints in tests for Python 3 Simon Marchi
2014-11-27 8:40 ` Joel Brobecker [this message]
2014-11-28 16:40 ` Simon Marchi
2014-11-26 4:36 ` [PATCH 2/3] Fix Python help() test " Simon Marchi
2014-11-27 8:47 ` Joel Brobecker
2014-11-28 15:57 ` Simon Marchi
2014-11-29 11:42 ` Joel Brobecker
2014-12-01 13:08 ` Simon Marchi
2014-11-27 9:00 ` [PATCH 1/3] python extended prompt: Use os.getcwd() instead of os.getcwdu() Joel Brobecker
2014-11-28 15:49 ` Simon Marchi
2014-11-29 11:42 ` Joel Brobecker
2014-12-05 20:36 ` Simon Marchi
2014-12-15 16:41 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141127084017.GE5042@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).