From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9025 invoked by alias); 27 Nov 2014 08:40:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9016 invoked by uid 89); 27 Nov 2014 08:40:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 27 Nov 2014 08:40:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id CF420116A68; Thu, 27 Nov 2014 03:40:26 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id aA25LzUFK-OF; Thu, 27 Nov 2014 03:40:26 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 628BB116A64; Thu, 27 Nov 2014 03:40:26 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id AA70F40F79; Thu, 27 Nov 2014 12:40:17 +0400 (RET) Date: Thu, 27 Nov 2014 08:40:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org, simon.marchi@polymtl.ca Subject: Re: [PATCH 3/3] Fix prints in tests for Python 3 Message-ID: <20141127084017.GE5042@adacore.com> References: <1416976561-1927-1-git-send-email-simon.marchi@ericsson.com> <1416976561-1927-3-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416976561-1927-3-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00682.txt.bz2 > Python 3's print requires to use parentheses, so this patch adds them where > they were missing. > > gdb/testsuite/ChangeLog: > > * gdb.python/py-linetable.exp: Add parentheses to calls to print. > * gdb.python/py-type.exp: Same. > * gdb.python/py-value-cc.exp: Same. > * gdb.python/py-value.exp: Same. Pre-approved with the same comment as before: Can you remove the space between "print" and "(", please? You can push any other changes of this nature under the "obvious" rule. Thank you! -- Joel