From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12047 invoked by alias); 27 Nov 2014 08:47:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12032 invoked by uid 89); 27 Nov 2014 08:47:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 27 Nov 2014 08:47:50 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 80EF611677D; Thu, 27 Nov 2014 03:47:48 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Aq9rUvcvQjla; Thu, 27 Nov 2014 03:47:48 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1F4EC116762; Thu, 27 Nov 2014 03:47:48 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 6754A40F79; Thu, 27 Nov 2014 12:47:44 +0400 (RET) Date: Thu, 27 Nov 2014 08:47:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org, simon.marchi@polymtl.ca Subject: Re: [PATCH 2/3] Fix Python help() test for Python 3 Message-ID: <20141127084744.GF5042@adacore.com> References: <1416976561-1927-1-git-send-email-simon.marchi@ericsson.com> <1416976561-1927-2-git-send-email-simon.marchi@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416976561-1927-2-git-send-email-simon.marchi@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00683.txt.bz2 > The message displayed when using help() changed a bit with time, so this > adjusts the test accordingly. > > gdb/testsuite/ChangeLog: > > * gdb.python/python.exp: Change expected reply to help(). I am OK with the patch as is, and verified with Python 2.3, 2.6, 2.7 and 3.4 that "Welcome to Python" is part of the output of the help() function. But since the purpose of the test is purely to verify that the help() function does not hang, just verifying that we have the prompt should achieve that goal, so I don't see a need to extend the the expected output to match the "Welcome [...]" message as well. I would personally just drop the "online" from the expected output. Just my 2 cents, either way is fine. Thank you! > --- > gdb/testsuite/gdb.python/python.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.python/python.exp b/gdb/testsuite/gdb.python/python.exp > index 787a294..7b4a5b8 100644 > --- a/gdb/testsuite/gdb.python/python.exp > +++ b/gdb/testsuite/gdb.python/python.exp > @@ -67,7 +67,7 @@ gdb_py_test_multiple "multi-line python command" \ > with_test_prefix "python interactive help" { > set test "python; help(); end" > gdb_test_multiple "python\nhelp()\nend" $test { > - -re "online help utility.*help> $" { > + -re "Welcome to Python.*help utility.*help> $" { > pass $test > > # The "quit" must be seen on the output. A buggy GDB > -- > 2.1.3 -- Joel