From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: sivachandra@google.com (Siva Chandra)
Cc: gdb-patches@sourceware.org (gdb-patches)
Subject: Re: [PATCH v6] Make chained function calls in expressions work
Date: Fri, 28 Nov 2014 12:10:00 -0000 [thread overview]
Message-ID: <201411281210.sASCAQGP013169@d03av02.boulder.ibm.com> (raw)
In-Reply-To: <CAGyQ6gxp5QS7t9C6WxG5pn2Wfzdtj6x2UJrsnD40PW6M7skZ5w@mail.gmail.com> from "Siva Chandra" at Nov 26, 2014 10:55:44 PM
Siva Chandra wrote:
> gdb/ChangeLog:
>
> 2014-11-27 Siva Chandra Reddy <sivachandra@google.com>
>
> * eval.c: Include gdbthread.h.
> (evaluate_subexp): Enable thread stack temporaries before
> evaluating a complete expression and clean them up after the
> evaluation is complete.
> * gdbthread.h: Include common/vec.h.
> (value_ptr): New typedef.
> (VEC (value_ptr)): New vector type.
> (value_vec): New typedef.
> (struct thread_info): Add new fields stack_temporaries_enabled
> and stack_temporaries.
> (enable_thread_stack_temporaries)
> (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
> (get_last_thread_stack_temporary)
> (value_in_thread_stack_temporaries): Declare.
> * gdbtypes.c (class_or_union_p): New function.
> * gdbtypes.h (class_or_union_p): Declare.
> * infcall.c (call_function_by_hand): Store return values of class
> type as temporaries on stack.
> * thread.c (enable_thread_stack_temporaries): New function.
> (thread_stack_temporaries_enabled_p, push_thread_stack_temporary)
> (get_last_thread_stack_temporary): Likewise.
> (value_in_thread_stack_temporaries): Likewise.
> * value.c (value_force_lval): New function.
> * value.h (value_force_lval): Declare.
>
> gdb/testsuite/ChangeLog:
>
> 2014-11-27 Siva Chandra Reddy <sivachandra@google.com>
>
> * gdb.cp/chained-calls.cc: New file.
> * gdb.cp/chained-calls.exp: New file.
> * gdb.cp/smartp.exp: Remove KFAIL for "p c2->inta".
This is OK.
Thanks for you patience in working through the many iterations on this patch!
One final nit:
>+/* Return an address after skipping over the current stack temporaries
>+ of thread with id PTID. SP is the current stack frame pointer. Non-zero
>+ DOWNWARD indicates that the stack grows downwards/backwards. */
>+
>+struct value *
>+get_last_thread_stack_temporary (ptid_t ptid)
Comment no longer fits the new semantics of the function.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2014-11-28 12:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 6:55 Siva Chandra
2014-11-28 12:10 ` Ulrich Weigand [this message]
2014-11-29 0:04 ` Siva Chandra
2014-11-29 8:26 ` Regression for gdb.cp/exceptprint.exp [Re: [PATCH v6] Make chained function calls in expressions work] Jan Kratochvil
2014-11-29 8:59 ` Siva Chandra
2014-11-29 9:13 ` Jan Kratochvil
2014-11-29 10:16 ` Siva Chandra
2014-11-29 12:38 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411281210.sASCAQGP013169@d03av02.boulder.ibm.com \
--to=uweigand@de.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sivachandra@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).