public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org, simon.marchi@polymtl.ca
Subject: Re: [PATCH 1/3] python extended prompt: Use os.getcwd() instead of os.getcwdu()
Date: Sat, 29 Nov 2014 11:42:00 -0000	[thread overview]
Message-ID: <20141129114203.GN5042@adacore.com> (raw)
In-Reply-To: <54789982.5020604@ericsson.com>

> > I'd like to have other people's opinion on this, as I am not sure.
> > 
> > I _think_ that the patch is not making things worse for us,
> > while making things a little better in situations as the above.
> > So, based on that, I'd be inclined to apply it.
> > 
> > However, I think the long term fix would be, I believe, to switch
> > the entire thing to unicode. With Python3, it's automatic, but
> > with Python2, we might have to add 'u'-s on every piece of string
> > in the module, and also add some conversions here and there.
> > That's why I am thinking that the long term fix should be a blocker
> > for this patch.
> >
> > Thoughts?
> 
> An eventual switch to use unicode everywhere would certainly undo this
> patch. However, I don't see the point in leaving the broken code as-is,
> unless there are imminent plans to make that switch happen.

That's exactly my thinking. But not being very familiar with this
area, and the handling of unicode, I would like to give others
an opportunity to jump in. Let's wait another week, and see if
we get additional feedback. If not, we'll push the patch.

-- 
Joel

  reply	other threads:[~2014-11-29 11:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26  4:36 Simon Marchi
2014-11-26  4:36 ` [PATCH 3/3] Fix prints in tests for Python 3 Simon Marchi
2014-11-27  8:40   ` Joel Brobecker
2014-11-28 16:40     ` Simon Marchi
2014-11-26  4:36 ` [PATCH 2/3] Fix Python help() test " Simon Marchi
2014-11-27  8:47   ` Joel Brobecker
2014-11-28 15:57     ` Simon Marchi
2014-11-29 11:42       ` Joel Brobecker
2014-12-01 13:08         ` Simon Marchi
2014-11-27  9:00 ` [PATCH 1/3] python extended prompt: Use os.getcwd() instead of os.getcwdu() Joel Brobecker
2014-11-28 15:49   ` Simon Marchi
2014-11-29 11:42     ` Joel Brobecker [this message]
2014-12-05 20:36       ` Simon Marchi
2014-12-15 16:41         ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141129114203.GN5042@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=simon.marchi@ericsson.com \
    --cc=simon.marchi@polymtl.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).