From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10949 invoked by alias); 30 Nov 2014 15:23:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 10890 invoked by uid 89); 30 Nov 2014 15:23:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sun, 30 Nov 2014 15:23:45 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 163661164B1; Sun, 30 Nov 2014 10:23:44 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tDXwbsiB8RmY; Sun, 30 Nov 2014 10:23:44 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id B1A811164A2; Sun, 30 Nov 2014 10:23:43 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8E03440EAE; Sun, 30 Nov 2014 19:23:39 +0400 (RET) Date: Sun, 30 Nov 2014 15:23:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't enable gdbtk in testsuite Message-ID: <20141130152339.GD4882@adacore.com> References: <1416903049-30419-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1416903049-30419-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-11/txt/msg00748.txt.bz2 > When I skim configure.ac and Makefile.in in gdb/testsuite, I happen to > see that directory gdb.gdbtk is added to subdirs, however it doesn't > exist. gdb/testsuite/gdb.gdbtk was removed by the patch below, > > [rfa] git repo fixup: delete gdb/testsuite/gdb.gdbtk > http://thread.gmane.org/gmane.comp.gdb.patches/61489 > > and we should cleanup configure.ac accordingly. > > gdb/testsuite: > > 2014-11-25 Yao Qi > > * configure.ac: Remove AC_ARG_ENABLE for gdbtk. Don't invoke > AC_CONFIG_SUBDIRS(gdb.gdbtk). > * configure: Re-generated. FWIW, the patch looks good to me, so you can go ahead and push. -- Joel