From: Joel Brobecker <brobecker@adacore.com>
To: Martin Galvan <martin.galvan@tallertechnologies.com>
Cc: gdb-patches@sourceware.org, daniel.gutson@tallertechnologies.com
Subject: Re: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq().
Date: Sun, 30 Nov 2014 15:41:00 -0000 [thread overview]
Message-ID: <20141130154110.GE4882@adacore.com> (raw)
In-Reply-To: <1416944088-8750-1-git-send-email-martin.galvan@tallertechnologies.com>
[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]
On Tue, Nov 25, 2014 at 04:34:48PM -0300, Martin Galvan wrote:
> I noticed in frame_id_eq() we were checking for the "l" frame_id being invalid twice instead of checking both "l" and "r", so I corrected it.
>
> gdb/ChangeLog:
>
> 2014-11-25 Martin Galvan <martin.galvan@tallertechnologies.com>
>
> * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID.
Thank you for the patch. It does indeed look pretty obvious.
You're patch did not apply for some reason, but since it was so
simple, I just redid it, bearing in mind Sergio's comments.
I then re-ran the testsuite on x86_64-linux to make sure it doesn't
cause any regression.
Attached is what I ended pushing (as both obvious and under 'tiny
patch' rule, meaning that you don't need a copyright assignment
for this change). If you are interested in contributing more patches
to GDB, you'll need a copyright assignement in place with the FSF.
Let us know and we will get you started; the process can be somewhat
lengthy.
--
Joel
[-- Attachment #2: 0001-frame.c-Fix-the-check-for-FID_STACK_INVALID-in-frame.patch --]
[-- Type: text/x-diff, Size: 1567 bytes --]
From 0bba2ddfa79b718e4bab94f2827165bd5b55c92c Mon Sep 17 00:00:00 2001
From: Martin Galvan <martin.galvan@tallertechnologies.com>
Date: Sun, 30 Nov 2014 19:34:15 +0400
Subject: [PATCH] frame.c: Fix the check for FID_STACK_INVALID in frame_id_eq()
I noticed in frame_id_eq() we were checking for the "l" frame_id being
invalid twice instead of checking both "l" and "r", so this patch
corrects it.
gdb/ChangeLog:
* frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID.
---
gdb/ChangeLog | 5 +++++
gdb/frame.c | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 4112438..f706f29 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-30 Martin Galvan <martin.galvan@tallertechnologies.com> (tiny patch, obvious)
+
+ Pushed by Joel Brobecker <brobecker@adacore.com>.
+ * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID.
+
2014-11-29 Siva Chandra Reddy <sivachandra@google.com>
* eval.c (evaluate_subexp): Check that the thread stack temporaries
diff --git a/gdb/frame.c b/gdb/frame.c
index 0663af9..75ad341 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -614,7 +614,7 @@ frame_id_eq (struct frame_id l, struct frame_id r)
outer_frame_id. */
eq = 1;
else if (l.stack_status == FID_STACK_INVALID
- || l.stack_status == FID_STACK_INVALID)
+ || r.stack_status == FID_STACK_INVALID)
/* Like a NaN, if either ID is invalid, the result is false.
Note that a frame ID is invalid iff it is the null frame ID. */
eq = 0;
--
1.9.1
prev parent reply other threads:[~2014-11-30 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 19:34 Martin Galvan
2014-11-25 20:33 ` Sergio Durigan Junior
2014-11-26 1:19 ` Martin Galvan
2014-11-30 15:41 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141130154110.GE4882@adacore.com \
--to=brobecker@adacore.com \
--cc=daniel.gutson@tallertechnologies.com \
--cc=gdb-patches@sourceware.org \
--cc=martin.galvan@tallertechnologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).