On Tue, Nov 25, 2014 at 04:34:48PM -0300, Martin Galvan wrote: > I noticed in frame_id_eq() we were checking for the "l" frame_id being invalid twice instead of checking both "l" and "r", so I corrected it. > > gdb/ChangeLog: > > 2014-11-25 Martin Galvan > > * frame.c (frame_id_eq): Fix the check for FID_STACK_INVALID. Thank you for the patch. It does indeed look pretty obvious. You're patch did not apply for some reason, but since it was so simple, I just redid it, bearing in mind Sergio's comments. I then re-ran the testsuite on x86_64-linux to make sure it doesn't cause any regression. Attached is what I ended pushing (as both obvious and under 'tiny patch' rule, meaning that you don't need a copyright assignment for this change). If you are interested in contributing more patches to GDB, you'll need a copyright assignement in place with the FSF. Let us know and we will get you started; the process can be somewhat lengthy. -- Joel