From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32348 invoked by alias); 1 Dec 2014 18:40:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32337 invoked by uid 89); 1 Dec 2014 18:40:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e37.co.us.ibm.com Received: from e37.co.us.ibm.com (HELO e37.co.us.ibm.com) (32.97.110.158) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 01 Dec 2014 18:40:14 +0000 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 1 Dec 2014 11:40:12 -0700 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e37.co.us.ibm.com (192.168.1.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 1 Dec 2014 11:40:10 -0700 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 7C6901FF0043 for ; Mon, 1 Dec 2014 11:28:54 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sB1IdEiw21168296 for ; Mon, 1 Dec 2014 11:39:14 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sB1Ie93e009777 for ; Mon, 1 Dec 2014 11:40:09 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id sB1Ie6As009411; Mon, 1 Dec 2014 11:40:07 -0700 Message-Id: <201412011840.sB1Ie6As009411@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 01 Dec 2014 19:40:02 +0100 Subject: Re: [PATCH 2/2] S390: Fix gdbserver support for TDB To: arnez@linux.vnet.ibm.com (Andreas Arnez) Date: Mon, 01 Dec 2014 18:40:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <87iohvp77u.fsf@br87z6lw.de.ibm.com> from "Andreas Arnez" at Dec 01, 2014 07:15:17 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14120118-0025-0000-0000-000006876F4C X-SW-Source: 2014-12/txt/msg00023.txt.bz2 Andreas Arnez wrote: > Here's an updated version of the patch. Instead of clearing the buffer, > this version passes a NULL pointer to the store function. And the store > function for iWMMXt is adjusted accordingly. Note that I've tested this > on S390, but not on ARM. I agree that this version is preferable to the first one. The patch looks good to me, but I'd like to give other maintainers (in particular for ARM) a chance to comment before approving it. Thanks, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com