From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <xdje42@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [patchv3 2/2] Accelerate lookup_symbol_aux_objfile 85x
Date: Wed, 03 Dec 2014 18:05:00 -0000 [thread overview]
Message-ID: <20141203180507.GF25020@host2.jankratochvil.net> (raw)
In-Reply-To: <m3ppc2698r.fsf@sspiff.org>
On Tue, 02 Dec 2014 04:06:28 +0100, Doug Evans wrote:
> I was reviewing all the callers of lookup_symbol_in_objfile_symtabs.
I do not see why, see below.
> This patch assumes we're looping over all objfiles,
No. each objfile is considered completely independent wrt various kinds of
symbol tables and their inter-refefences.
Function block_lookup_symbol_primary() assumes we're looping over all
'compunit_symtabs's (of an objfile). This is satisfied by the current only
caller of block_lookup_symbol_primary()
(which is lookup_symbol_in_objfile_symtabs()).
> but some callers aren't. e.g., lookup_symbol_in_objfile_from_linkage_name.
> It seems like we'll need to make a copy of lookup_symbol_in_objfile_symtabs
> and call that in lookup_symbol_in_objfile (plus I'd add some comments
> to lookup_symbol_in_objfile warning the reader that included symtabs
> are not searched).
>
> I could be missing something though.
I also can be missing something but I do not see why
block_lookup_symbol_primary() should have any dependencies on other objfiles
than the one that is passed to it.
Thanks,
Jan
next prev parent reply other threads:[~2014-12-03 18:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 21:44 [patch 0/2] Accelerate symbol lookups 15x Jan Kratochvil
2014-10-22 8:55 ` Doug Evans
2014-10-23 18:24 ` [patchv2 2/2] Accelerate lookup_symbol_aux_objfile 14.5x [Re: [patch 0/2] Accelerate symbol lookups 15x] Jan Kratochvil
2014-10-24 7:16 ` Doug Evans
2014-10-24 7:33 ` Jan Kratochvil
2014-10-24 16:07 ` Doug Evans
2014-10-27 5:55 ` Doug Evans
2014-10-27 6:02 ` Doug Evans
2014-10-27 8:54 ` Jan Kratochvil
2014-11-29 12:11 ` [patchv3 2/2] Accelerate lookup_symbol_aux_objfile 85x Jan Kratochvil
2014-12-02 3:07 ` Doug Evans
2014-12-03 18:05 ` Jan Kratochvil [this message]
2014-12-04 6:21 ` Doug Evans
2014-12-04 7:27 ` [commit] " Jan Kratochvil
2014-10-22 8:57 ` [patch 0/2] Accelerate symbol lookups 15x Doug Evans
2014-10-24 7:19 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141203180507.GF25020@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).