From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29660 invoked by alias); 3 Dec 2014 18:05:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29649 invoked by uid 89); 3 Dec 2014 18:05:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 03 Dec 2014 18:05:13 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB3I5ARA022091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 3 Dec 2014 13:05:10 -0500 Received: from host2.jankratochvil.net (ovpn-116-31.ams2.redhat.com [10.36.116.31]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB3I57gd010077 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 3 Dec 2014 13:05:10 -0500 Date: Wed, 03 Dec 2014 18:05:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: "gdb-patches@sourceware.org" Subject: Re: [patchv3 2/2] Accelerate lookup_symbol_aux_objfile 85x Message-ID: <20141203180507.GF25020@host2.jankratochvil.net> References: <20141020214410.GA22011@host2.jankratochvil.net> <20141023182434.GA31412@host2.jankratochvil.net> <20141129121124.GA21606@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2014-12/txt/msg00073.txt.bz2 On Tue, 02 Dec 2014 04:06:28 +0100, Doug Evans wrote: > I was reviewing all the callers of lookup_symbol_in_objfile_symtabs. I do not see why, see below. > This patch assumes we're looping over all objfiles, No. each objfile is considered completely independent wrt various kinds of symbol tables and their inter-refefences. Function block_lookup_symbol_primary() assumes we're looping over all 'compunit_symtabs's (of an objfile). This is satisfied by the current only caller of block_lookup_symbol_primary() (which is lookup_symbol_in_objfile_symtabs()). > but some callers aren't. e.g., lookup_symbol_in_objfile_from_linkage_name. > It seems like we'll need to make a copy of lookup_symbol_in_objfile_symtabs > and call that in lookup_symbol_in_objfile (plus I'd add some comments > to lookup_symbol_in_objfile warning the reader that included symtabs > are not searched). > > I could be missing something though. I also can be missing something but I do not see why block_lookup_symbol_primary() should have any dependencies on other objfiles than the one that is passed to it. Thanks, Jan