From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21095 invoked by alias); 4 Dec 2014 03:18:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21080 invoked by uid 89); 4 Dec 2014 03:18:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 04 Dec 2014 03:18:34 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 1E8E2116637; Wed, 3 Dec 2014 22:18:32 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 4EEReDfqHFGQ; Wed, 3 Dec 2014 22:18:32 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id A08EF116580; Wed, 3 Dec 2014 22:18:31 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 98A4346B66; Thu, 4 Dec 2014 07:18:28 +0400 (RET) Date: Thu, 04 Dec 2014 03:18:00 -0000 From: Joel Brobecker To: Eli Zaretskii Cc: gdb-patches@sourceware.org, yao@codesourcery.com Subject: Re: [RFA] configure gdb/gnulib with --disable-largefile if largefile support disabled. Message-ID: <20141204031828.GD7899@adacore.com> References: <20141203104812.GA14666@adacore.com> <1417608509-15533-1-git-send-email-brobecker@adacore.com> <83h9xc62dw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83h9xc62dw.fsf@gnu.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00079.txt.bz2 > > But gnulib ignores this fact, and so tries to determine how to > > enable large-file support irrespective of whether we want it or not. > > This patch fixes the issue by passing --disable-largefile to gnulib's > > configure when large-file support in GDB is disabled. This is done > > by first enhancing ACX_CONFIGURE_DIR to allow us to pass extra > > arguments to be passed to the configure command, and then by modifying > > GDB's configure to pass --disable-largefile if large-file support > > is disabled. > > Shouldn't this be reported to gnulib folks and preferably fixed there? I do not think so, because gnulib can be used independently of procfs, in which case you would probably want gnulib to have large-file support by default. It's only in GDB and binutils' peculiar situation that we need to disable by default. -- Joel