From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16214 invoked by alias); 8 Dec 2014 19:13:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16197 invoked by uid 89); 8 Dec 2014 19:13:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e32.co.us.ibm.com Received: from e32.co.us.ibm.com (HELO e32.co.us.ibm.com) (32.97.110.150) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 08 Dec 2014 19:13:35 +0000 Received: from /spool/local by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 Dec 2014 12:13:34 -0700 Received: from d03dlp03.boulder.ibm.com (9.17.202.179) by e32.co.us.ibm.com (192.168.1.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 8 Dec 2014 12:13:31 -0700 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 5696D19D803E for ; Mon, 8 Dec 2014 12:02:10 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sB8JDUQg34340900 for ; Mon, 8 Dec 2014 12:13:30 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sB8JDSiJ004060 for ; Mon, 8 Dec 2014 12:13:30 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id sB8JDOfU003481; Mon, 8 Dec 2014 12:13:25 -0700 Message-Id: <201412081913.sB8JDOfU003481@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 08 Dec 2014 20:13:24 +0100 Subject: Re: [PATCH 3/3 v2] Process record support for PowerPC To: cole945@gmail.com (Wei-cheng Wang) Date: Mon, 08 Dec 2014 19:13:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <54834450.3020506@gmail.com> from "Wei-cheng Wang" at Dec 07, 2014 02:00:48 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14120819-0005-0000-0000-000006F79EEA X-SW-Source: 2014-12/txt/msg00184.txt.bz2 Wei-cheng Wang wrote: > * ppc-linux-tdep.c (powerpc_linux_in_dynsym_resolve_code): > Scan PLT stub backward for reverse debugging. > (ppc_linux_init_abi): set powerpc_linux_in_dynsym_resolve_code > for both 32-bit and 64-bit. As I said in the reply to the 0/3 mail, I really think it would be better to handle this within the PPC skip_trampoline_code implementation, instead of having in_dynsym_resolve_code suddenly also cover the trampolines ... Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com