From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: arnez@linux.vnet.ibm.com (Andreas Arnez)
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 3/3] S390: Fix gdbserver support for TDB
Date: Wed, 10 Dec 2014 19:16:00 -0000 [thread overview]
Message-ID: <201412101916.sBAJG9x7025122@d03av02.boulder.ibm.com> (raw)
In-Reply-To: <1418133563-16378-4-git-send-email-arnez@linux.vnet.ibm.com> from "Andreas Arnez" at Dec 09, 2014 02:59:23 PM
Andreas Arnez wrote:
> @@ -4256,7 +4256,7 @@ regsets_fetch_inferior_registers (struct regsets_info *regsets_info,
> this process mode. */
> disable_regset (regsets_info, regset);
> }
> - else
> + else if (errno != ENODATA)
> {
> char s[256];
> sprintf (s, "ptrace(regsets_fetch_inferior_registers) PID=%d",
It would be better to keep the comment explaining in what situations the kernel
can return ENODATA that you had in a previous iteration of the patch set.
> @@ -4293,7 +4293,8 @@ regsets_store_inferior_registers (struct regsets_info *regsets_info,
> void *buf, *data;
> int nt_type, res;
>
> - if (regset->size == 0 || regset_disabled (regsets_info, regset))
> + if (regset->size == 0 || regset_disabled (regsets_info, regset)
> + || regset->fill_function == NULL)
> continue;
This (and the related s390_fill_last_break change) is really an independent
change; maybe do it as a separate patch? For consistency, we might likewise
want to allow regsets with NULL store_function (in regsets_fetch_inferior_registers).
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2014-12-10 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 13:59 [PATCH v3 0/3] gdbserver: Fix support for S390 TDB Andreas Arnez
2014-12-09 13:59 ` [PATCH v3 3/3] S390: Fix gdbserver support for TDB Andreas Arnez
2014-12-10 19:16 ` Ulrich Weigand [this message]
2014-12-11 17:04 ` Andreas Arnez
2014-12-11 20:16 ` Ulrich Weigand
2014-12-09 13:59 ` [PATCH v3 2/3] gdbserver: Prevent stale/random values in register cache Andreas Arnez
2014-12-10 19:14 ` Ulrich Weigand
2014-12-11 17:05 ` Andreas Arnez
2014-12-09 13:59 ` [PATCH v3 1/3] gdbserver: Rephrase loops in regsets_fetch/store_inferior_registers Andreas Arnez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412101916.sBAJG9x7025122@d03av02.boulder.ibm.com \
--to=uweigand@de.ibm.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).