From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19479 invoked by alias); 10 Dec 2014 19:16:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19469 invoked by uid 89); 10 Dec 2014 19:16:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e33.co.us.ibm.com Received: from e33.co.us.ibm.com (HELO e33.co.us.ibm.com) (32.97.110.151) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 10 Dec 2014 19:16:16 +0000 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Dec 2014 12:16:14 -0700 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e33.co.us.ibm.com (192.168.1.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 10 Dec 2014 12:16:12 -0700 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 10AA21FF0021 for ; Wed, 10 Dec 2014 12:04:56 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id sBAJGYB519660882 for ; Wed, 10 Dec 2014 12:16:34 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id sBAJGBlN025446 for ; Wed, 10 Dec 2014 12:16:11 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id sBAJG9x7025122; Wed, 10 Dec 2014 12:16:09 -0700 Message-Id: <201412101916.sBAJG9x7025122@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Wed, 10 Dec 2014 20:16:08 +0100 Subject: Re: [PATCH v3 3/3] S390: Fix gdbserver support for TDB To: arnez@linux.vnet.ibm.com (Andreas Arnez) Date: Wed, 10 Dec 2014 19:16:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <1418133563-16378-4-git-send-email-arnez@linux.vnet.ibm.com> from "Andreas Arnez" at Dec 09, 2014 02:59:23 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14121019-0009-0000-0000-00000708629A X-SW-Source: 2014-12/txt/msg00228.txt.bz2 Andreas Arnez wrote: > @@ -4256,7 +4256,7 @@ regsets_fetch_inferior_registers (struct regsets_info *regsets_info, > this process mode. */ > disable_regset (regsets_info, regset); > } > - else > + else if (errno != ENODATA) > { > char s[256]; > sprintf (s, "ptrace(regsets_fetch_inferior_registers) PID=%d", It would be better to keep the comment explaining in what situations the kernel can return ENODATA that you had in a previous iteration of the patch set. > @@ -4293,7 +4293,8 @@ regsets_store_inferior_registers (struct regsets_info *regsets_info, > void *buf, *data; > int nt_type, res; > > - if (regset->size == 0 || regset_disabled (regsets_info, regset)) > + if (regset->size == 0 || regset_disabled (regsets_info, regset) > + || regset->fill_function == NULL) > continue; This (and the related s390_fill_last_break change) is really an independent change; maybe do it as a separate patch? For consistency, we might likewise want to allow regsets with NULL store_function (in regsets_fetch_inferior_registers). Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com