From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9110 invoked by alias); 15 Dec 2014 13:10:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8964 invoked by uid 89); 15 Dec 2014 13:10:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Dec 2014 13:10:33 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 409B1116502; Mon, 15 Dec 2014 08:10:32 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Yw4r17wh6Y3Y; Mon, 15 Dec 2014 08:10:32 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1DB391164FD; Mon, 15 Dec 2014 08:10:32 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 4D65540164; Mon, 15 Dec 2014 08:10:32 -0500 (EST) Date: Mon, 15 Dec 2014 13:10:00 -0000 From: Joel Brobecker To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] MIPS SDE OS ABI support Message-ID: <20141215131032.GW5457@adacore.com> References: <1418629607-20086-1-git-send-email-yao@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1418629607-20086-1-git-send-email-yao@codesourcery.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00382.txt.bz2 > 2014-12-15 Maciej W. Rozycki > Nigel Stephens > Chris Dearman > Luis Machado > > * sde-mips-tdep.c: New file containg SDE specific code. > * configure.tgt (mips*-sde*-elf*): Add sde-mips-tdep.o to > gdb_target_obs. > * defs.h (gdb_osabi): Add GDB_OSABI_SDE. > * osabi.c (gdb_osabi_names): Add SDE. > * NEWS: Mention the change. I just skimmed through that patch, and noticed a few things, all of fairly trivial nature. So, as soon as fixed, I think the patch can go in (modulo NEWS to be approved by Eli). > +static struct trad_frame_cache * > +mips_sde_frame_cache (struct frame_info *this_frame, void **this_cache) All functions should have an introductory comment. Since these implement callbacks/"methods", the usual one-liner that describe which callback they implement should be used. > +static void > +mips_sde_frame_this_id (struct frame_info *this_frame, void **this_cache, > + struct frame_id *this_id) > +{ > + struct trad_frame_cache *this_trad_cache > + = mips_sde_frame_cache (this_frame, this_cache); > + trad_frame_get_id (this_trad_cache, this_id); Empty line between variable declaration and the rest of the code. > +static struct value * > +mips_sde_frame_prev_register (struct frame_info *this_frame, > + void **this_cache, > + int prev_regnum) > +{ > + struct trad_frame_cache *trad_cache > + = mips_sde_frame_cache (this_frame, this_cache); > + return trad_frame_get_register (trad_cache, this_frame, prev_regnum); Likewise. > +static CORE_ADDR > +mips_sde_frame_base_address (struct frame_info *this_frame, void **this_cache) > +{ > + struct trad_frame_cache *this_trad_cache > + = mips_sde_frame_cache (this_frame, this_cache); > + return trad_frame_get_this_base (this_trad_cache); Same here. -- Joel