Re: [patch+7.8] Fix 7.8 regression: resolve_dynamic_struct: Assertion `TYPE_NFIELDS (type) > 0' (PR 17642)

[Joel Brobecker <brobecker@adacore.com>]

Hi Jan,

> > gdb/
> > 2014-11-25  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	Fix internal error on stubs of dynamic types.
> > 	* gdbtypes.c (resolve_dynamic_type_internal): Apply check_typedef to
> > 	TYPE if not TYPE_CODE_TYPEDEF.
> > 
> > gdb/testsuite/
> > 2014-11-25  Jan Kratochvil  <jan.kratochvil@redhat.com>
> > 
> > 	Fix internal error on stubs of dynamic types.
> > 	* gdb.base/vla-stub-define.c: New file.
> > 	* gdb.base/vla-stub.c: New file.
> > 	* gdb.base/vla-stub.exp: New file.
> 
> Pre-approved with the following comments. Ok for 7.8 as well, although
> the chances of a 7.8.2 are getting slimmer, and you'll need also to
> create a PR.

I took a look at the todo list for 7.8 again this morning, and found
that there is not just...

    PR gdb/17525 (target-async: breakpoint commands not executed when
                  program run from -x script)

... which I remembered, but also...

    PR gdb/16215 (SPARC: can't compute CFA for this frame)

... which I had forgotten about, and makes debugging on sparc
completely broken with GCC 4.9. Combined with your patch, we might
want to produce a 7.8.2 after all. So, if you'd like, you could
push your patch on the branch as well.

Sorry for changing my tune on this, but I has just forgotten about
the situation on SPARC!

Thanks,
-- 
Joel