From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13482 invoked by alias); 15 Dec 2014 15:06:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13424 invoked by uid 89); 15 Dec 2014 15:06:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Dec 2014 15:06:11 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 4592A11651E; Mon, 15 Dec 2014 10:06:09 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Z4jICvvxfq9M; Mon, 15 Dec 2014 10:06:09 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 2DBF811639F; Mon, 15 Dec 2014 10:06:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 7FF3640164; Mon, 15 Dec 2014 10:06:09 -0500 (EST) Date: Mon, 15 Dec 2014 15:06:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patch+7.8] Fix 7.8 regression: resolve_dynamic_struct: Assertion `TYPE_NFIELDS (type) > 0' (PR 17642) Message-ID: <20141215150609.GA4229@adacore.com> References: <20141125195444.GA3400@host2.jankratochvil.net> <20141213142351.GG5457@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141213142351.GG5457@adacore.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00391.txt.bz2 Hi Jan, > > gdb/ > > 2014-11-25 Jan Kratochvil > > > > Fix internal error on stubs of dynamic types. > > * gdbtypes.c (resolve_dynamic_type_internal): Apply check_typedef to > > TYPE if not TYPE_CODE_TYPEDEF. > > > > gdb/testsuite/ > > 2014-11-25 Jan Kratochvil > > > > Fix internal error on stubs of dynamic types. > > * gdb.base/vla-stub-define.c: New file. > > * gdb.base/vla-stub.c: New file. > > * gdb.base/vla-stub.exp: New file. > > Pre-approved with the following comments. Ok for 7.8 as well, although > the chances of a 7.8.2 are getting slimmer, and you'll need also to > create a PR. I took a look at the todo list for 7.8 again this morning, and found that there is not just... PR gdb/17525 (target-async: breakpoint commands not executed when program run from -x script) ... which I remembered, but also... PR gdb/16215 (SPARC: can't compute CFA for this frame) ... which I had forgotten about, and makes debugging on sparc completely broken with GCC 4.9. Combined with your patch, we might want to produce a 7.8.2 after all. So, if you'd like, you could push your patch on the branch as well. Sorry for changing my tune on this, but I has just forgotten about the situation on SPARC! Thanks, -- Joel