public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Yao Qi <yao@codesourcery.com>,
	gdb-patches@sourceware.org,	Kai Tietz <ktietz@redhat.com>
Subject: Re: [mingw rfc] Add mkdtemp to gdb/gnulib/  [Re: [PATCH v4 14/14] the "compile" command]
Date: Mon, 15 Dec 2014 18:14:00 -0000	[thread overview]
Message-ID: <20141215181449.GA5457@adacore.com> (raw)
In-Reply-To: <20141215171225.GA19674@host2.jankratochvil.net>

> Does it mean that after upgrading gnulib we can drop the MS-Windows host
> routines (which need to be written yet) again?

Provided that the corresponding gnulib modules can in fact be
imported without problem, then my answer would be yes. As you
found out, it often does not work that way. So far, if you look
at your update, and yao's update not so long ago, it's 3 breakages
(I found 2, you found 1).  gnulib provides a really nice abstraction
layer, but it does not always work the way we hoped!

> IMO a more clean solution would be s/gdb_select/select/g, drop
> gdb_select from mingw-hdep.c and import gnulib select instead which
> handles what gdb_select is there fore, hopefully more transparently.
> But I haven't tried any of that.

As Eli pointed out, it's not necessarily an easy change. I don't
see the relation between select and mkdtemp, but maybe I missed
something.

-- 
Joel

  parent reply	other threads:[~2014-12-15 18:14 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-23 19:27 [PATCH v4 00/14] let gdb reuse gcc's C compiler Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 03/14] add some missing ops to DWARF assembler Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 02/14] add gcc/gdb interface files Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 04/14] add make_unqualified_type Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 01/14] introduce ui_file_write_for_put Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 06/14] add infcall_mmap and gcc_target_options gdbarch methods Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 05/14] add dummy frame destructor Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 13/14] add s390_gcc_target_options Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 11/14] export dwarf2_reg_to_regnum_or_error Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 12/14] add linux_infcall_mmap Jan Kratochvil
2014-12-15 12:41   ` Ulrich Weigand
2014-12-15 13:49     ` Yao Qi
2014-12-15 16:48       ` Jan Kratochvil
2014-12-16  5:27         ` Yao Qi
2014-11-23 19:28 ` [PATCH v4 08/14] introduce call_function_by_hand_dummy Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 10/14] make dwarf_expr_frame_base_1 public Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 07/14] add gnu_triplet_regexp gdbarch method Jan Kratochvil
2014-11-23 19:29 ` [PATCH v4 14/14] the "compile" command Jan Kratochvil
2014-12-14  6:05   ` Yao Qi
2014-12-14  7:53     ` Jan Kratochvil
2014-12-14  8:54       ` Yao Qi
2014-12-14 18:24         ` [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command] Jan Kratochvil
2014-12-15  3:16           ` Yao Qi
2014-12-15 12:44             ` Joel Brobecker
2014-12-15 13:11               ` Kai Tietz
2014-12-15 13:24               ` Yao Qi
2014-12-15 17:12               ` Jan Kratochvil
2014-12-15 17:48                 ` Eli Zaretskii
2014-12-15 18:14                 ` Joel Brobecker [this message]
2014-12-15 18:21                   ` Jan Kratochvil
2014-12-15 18:35                     ` Joel Brobecker
2014-12-15 18:40                       ` Jan Kratochvil
2014-12-15 18:57                         ` Eli Zaretskii
2014-12-15 22:28                           ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Jan Kratochvil
2014-12-15 22:56                             ` Jan Kratochvil
2014-12-16  3:40                               ` Eli Zaretskii
2014-12-16  9:04                                 ` Kai Tietz
2014-12-17 21:02                                   ` [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build] Jan Kratochvil
2014-12-17 22:07                                     ` Steve Ellcey
2014-12-17 22:42                                     ` Pedro Alves
2014-12-18 18:14                                       ` Jan Kratochvil
2014-12-18 18:24                                         ` Pedro Alves
2014-12-18 18:41                                           ` Jan Kratochvil
2014-12-18 19:07                                             ` Pedro Alves
2014-12-18 21:05                                               ` Jan Kratochvil
2014-12-18 21:11                                                 ` Eli Zaretskii
2014-12-18 21:24                                                   ` Jan Kratochvil
2014-12-18 22:18                                                     ` Sergio Durigan Junior
2014-12-18 23:06                                                     ` Pedro Alves
2014-12-19  0:12                                                       ` Jan Kratochvil
2014-12-19 10:48                                                         ` Pedro Alves
2014-12-19  8:24                                                     ` Eli Zaretskii
2014-12-19 12:59                                             ` Joel Brobecker
2014-12-18 20:26                                         ` Eli Zaretskii
2014-12-18  5:38                                     ` Yao Qi
2014-12-18 17:23                                     ` Eli Zaretskii
2014-12-18 17:31                                       ` Jan Kratochvil
2014-12-18 17:40                                         ` Eli Zaretskii
2014-12-18 20:15                                           ` Kai Tietz
2014-12-18 20:47                                             ` Eli Zaretskii
2014-12-18 20:55                                               ` Kai Tietz
2014-12-18 23:47                                             ` Pedro Alves
2014-12-19  9:28                                               ` Kai Tietz
2014-12-19 19:25                                               ` Jan Kratochvil
2014-12-19 20:55                                                 ` Jan Kratochvil
2014-12-20 12:26                                                 ` Joel Brobecker
2014-12-18 20:56                                     ` Sergio Durigan Junior
2014-12-17 17:30                                 ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Steve Ellcey
2014-12-16  3:37                             ` Eli Zaretskii
2014-12-16  9:06                               ` Kai Tietz
2014-12-17 19:18                               ` Jan Kratochvil
2014-12-17 19:31                                 ` Eli Zaretskii
2014-12-17 19:37                                   ` Jan Kratochvil
2014-12-17 20:34                                   ` Pedro Alves
2014-12-18 17:22                                     ` Eli Zaretskii
2014-12-18 18:00                                       ` Pedro Alves
2014-12-16 12:40                             ` Pierre Muller
2014-12-17 18:21                               ` Jan Kratochvil
2014-12-17  1:22                             ` Yao Qi
2014-12-17 10:57                               ` Pedro Alves
2014-12-17 11:40                                 ` Yao Qi
2014-12-17 11:43                                   ` Pedro Alves
2014-12-17 11:56                                     ` Yao Qi
2014-12-17 19:15                                     ` Jan Kratochvil
2014-12-17 11:16                             ` Pedro Alves
2014-12-17 18:17                               ` [patchv2] " Jan Kratochvil
2014-12-17 18:33                                 ` Pedro Alves
2014-12-17 19:12                                   ` [commit] " Jan Kratochvil
2014-12-05 18:29 ` [patch 15/14] GDB/GCC compile function pointers [Re: [PATCH v4 00/14] let gdb reuse gcc's C compiler] Jan Kratochvil
2014-12-12 21:51   ` obsolete: " Jan Kratochvil
2014-12-12 14:40 ` [PATCH v4 00/14] let gdb reuse gcc's C compiler Pedro Alves
2014-12-12 21:46   ` [commit all 14 parts] " Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141215181449.GA5457@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=ktietz@redhat.com \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).