From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21957 invoked by alias); 15 Dec 2014 18:14:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21945 invoked by uid 89); 15 Dec 2014 18:14:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 15 Dec 2014 18:14:51 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B19561163C2; Mon, 15 Dec 2014 13:14:49 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id vMb3beVh8mQq; Mon, 15 Dec 2014 13:14:49 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8DB3B1163BD; Mon, 15 Dec 2014 13:14:49 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D80E640166; Mon, 15 Dec 2014 13:14:49 -0500 (EST) Date: Mon, 15 Dec 2014 18:14:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Yao Qi , gdb-patches@sourceware.org, Kai Tietz Subject: Re: [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command] Message-ID: <20141215181449.GA5457@adacore.com> References: <20141123192713.32193.57150.stgit@host1.jankratochvil.net> <20141123192900.32193.65726.stgit@host1.jankratochvil.net> <87r3w2vkhv.fsf@codesourcery.com> <20141214075258.GA26795@host2.jankratochvil.net> <87egs2vcfu.fsf@codesourcery.com> <20141214182341.GA2908@host2.jankratochvil.net> <87a92pvc0w.fsf@codesourcery.com> <20141215124358.GU5457@adacore.com> <20141215171225.GA19674@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141215171225.GA19674@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2014-12/txt/msg00409.txt.bz2 > Does it mean that after upgrading gnulib we can drop the MS-Windows host > routines (which need to be written yet) again? Provided that the corresponding gnulib modules can in fact be imported without problem, then my answer would be yes. As you found out, it often does not work that way. So far, if you look at your update, and yao's update not so long ago, it's 3 breakages (I found 2, you found 1). gnulib provides a really nice abstraction layer, but it does not always work the way we hoped! > IMO a more clean solution would be s/gdb_select/select/g, drop > gdb_select from mingw-hdep.c and import gnulib select instead which > handles what gdb_select is there fore, hopefully more transparently. > But I haven't tried any of that. As Eli pointed out, it's not necessarily an easy change. I don't see the relation between select and mkdtemp, but maybe I missed something. -- Joel