From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: Kai Tietz <ktietz@redhat.com>, Eli Zaretskii <eliz@gnu.org>,
sellcey@imgtec.com, brobecker@adacore.com,
yao@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build]
Date: Fri, 19 Dec 2014 19:25:00 -0000 [thread overview]
Message-ID: <20141219192457.GA28791@host2.jankratochvil.net> (raw)
In-Reply-To: <5493678F.4050906@redhat.com>
On Fri, 19 Dec 2014 00:47:27 +0100, Pedro Alves wrote:
> For our purposes, both APIs are just as good (*). It's just
> that ftw has System V roots, while fts has BSD roots.
>
> In practice, programs that use fts instead are just, if not
> more portable.
>
> But, as I mentioned, gnulib provides an fts replacement
> for systems that don't have it. So if we use fts instead, we're
> good to go everywhere.
Linux fts man page
http://man7.org/linux/man-pages/man3/fts.3.html
says
BUGS
All of the APIs described in this man page are not safe when
compiling a program using the LFS APIs (e.g., when compiling with
-D_FILE_OFFSET_BITS=64).
and _FILE_OFFSET_BITS=64 happens on 32-bit hosts and --enable-64-bit-bfd.
Contrary to it gnulib fts documentation
https://www.gnu.org/software/gnulib/manual/html_node/fts_005fread.html
says
On platforms where off_t is a 32-bit type, this function may not
correctly report the size of files or block devices larger than 2 GB
and may not work correctly on huge directories larger than 2 GB. Also,
on platforms where ino_t is a 32-bit type, this function may report
inode numbers incorrectly. The fix is to use the AC_SYS_LARGEFILE
macro (only on Mac OS X systems).
This would suggest as if GDB should be compatible with 32-bit hosts and
--enable-64-bit-bfd GDB should use gnulib fts even on Linux; but I guess the
gnulib fts replacement would not be active on Linux.
The temporary files being deleted are never larger than 2GB nor their size is
read. So I hope nobody is going address these issues (I would add 32-bit
hosts are not relevant anymore anyway).
Jan
next prev parent reply other threads:[~2014-12-19 19:25 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 19:27 [PATCH v4 00/14] let gdb reuse gcc's C compiler Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 04/14] add make_unqualified_type Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 01/14] introduce ui_file_write_for_put Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 02/14] add gcc/gdb interface files Jan Kratochvil
2014-11-23 19:27 ` [PATCH v4 03/14] add some missing ops to DWARF assembler Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 08/14] introduce call_function_by_hand_dummy Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 10/14] make dwarf_expr_frame_base_1 public Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 07/14] add gnu_triplet_regexp gdbarch method Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 06/14] add infcall_mmap and gcc_target_options gdbarch methods Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 09/14] split dwarf2_fetch_cfa_info from dwarf2_compile_expr_to_ax Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 05/14] add dummy frame destructor Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 13/14] add s390_gcc_target_options Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 11/14] export dwarf2_reg_to_regnum_or_error Jan Kratochvil
2014-11-23 19:28 ` [PATCH v4 12/14] add linux_infcall_mmap Jan Kratochvil
2014-12-15 12:41 ` Ulrich Weigand
2014-12-15 13:49 ` Yao Qi
2014-12-15 16:48 ` Jan Kratochvil
2014-12-16 5:27 ` Yao Qi
2014-11-23 19:29 ` [PATCH v4 14/14] the "compile" command Jan Kratochvil
2014-12-14 6:05 ` Yao Qi
2014-12-14 7:53 ` Jan Kratochvil
2014-12-14 8:54 ` Yao Qi
2014-12-14 18:24 ` [mingw rfc] Add mkdtemp to gdb/gnulib/ [Re: [PATCH v4 14/14] the "compile" command] Jan Kratochvil
2014-12-15 3:16 ` Yao Qi
2014-12-15 12:44 ` Joel Brobecker
2014-12-15 13:11 ` Kai Tietz
2014-12-15 13:24 ` Yao Qi
2014-12-15 17:12 ` Jan Kratochvil
2014-12-15 17:48 ` Eli Zaretskii
2014-12-15 18:14 ` Joel Brobecker
2014-12-15 18:21 ` Jan Kratochvil
2014-12-15 18:35 ` Joel Brobecker
2014-12-15 18:40 ` Jan Kratochvil
2014-12-15 18:57 ` Eli Zaretskii
2014-12-15 22:28 ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Jan Kratochvil
2014-12-15 22:56 ` Jan Kratochvil
2014-12-16 3:40 ` Eli Zaretskii
2014-12-16 9:04 ` Kai Tietz
2014-12-17 21:02 ` [patch] compile: rm -rf -> ftw()+rmdir()+unlink() [Re: [patch] compile: Fix MinGW build] Jan Kratochvil
2014-12-17 22:07 ` Steve Ellcey
2014-12-17 22:42 ` Pedro Alves
2014-12-18 18:14 ` Jan Kratochvil
2014-12-18 18:24 ` Pedro Alves
2014-12-18 18:41 ` Jan Kratochvil
2014-12-18 19:07 ` Pedro Alves
2014-12-18 21:05 ` Jan Kratochvil
2014-12-18 21:11 ` Eli Zaretskii
2014-12-18 21:24 ` Jan Kratochvil
2014-12-18 22:18 ` Sergio Durigan Junior
2014-12-18 23:06 ` Pedro Alves
2014-12-19 0:12 ` Jan Kratochvil
2014-12-19 10:48 ` Pedro Alves
2014-12-19 8:24 ` Eli Zaretskii
2014-12-19 12:59 ` Joel Brobecker
2014-12-18 20:26 ` Eli Zaretskii
2014-12-18 5:38 ` Yao Qi
2014-12-18 17:23 ` Eli Zaretskii
2014-12-18 17:31 ` Jan Kratochvil
2014-12-18 17:40 ` Eli Zaretskii
2014-12-18 20:15 ` Kai Tietz
2014-12-18 20:47 ` Eli Zaretskii
2014-12-18 20:55 ` Kai Tietz
2014-12-18 23:47 ` Pedro Alves
2014-12-19 9:28 ` Kai Tietz
2014-12-19 19:25 ` Jan Kratochvil [this message]
2014-12-19 20:55 ` Jan Kratochvil
2014-12-20 12:26 ` Joel Brobecker
2014-12-18 20:56 ` Sergio Durigan Junior
2014-12-17 17:30 ` [patch] compile: Fix MinGW build [Re: [mingw rfc] Add mkdtemp to gdb/gnulib/] Steve Ellcey
2014-12-16 3:37 ` Eli Zaretskii
2014-12-16 9:06 ` Kai Tietz
2014-12-17 19:18 ` Jan Kratochvil
2014-12-17 19:31 ` Eli Zaretskii
2014-12-17 19:37 ` Jan Kratochvil
2014-12-17 20:34 ` Pedro Alves
2014-12-18 17:22 ` Eli Zaretskii
2014-12-18 18:00 ` Pedro Alves
2014-12-16 12:40 ` Pierre Muller
2014-12-17 18:21 ` Jan Kratochvil
2014-12-17 1:22 ` Yao Qi
2014-12-17 10:57 ` Pedro Alves
2014-12-17 11:40 ` Yao Qi
2014-12-17 11:43 ` Pedro Alves
2014-12-17 11:56 ` Yao Qi
2014-12-17 19:15 ` Jan Kratochvil
2014-12-17 11:16 ` Pedro Alves
2014-12-17 18:17 ` [patchv2] " Jan Kratochvil
2014-12-17 18:33 ` Pedro Alves
2014-12-17 19:12 ` [commit] " Jan Kratochvil
2014-12-05 18:29 ` [patch 15/14] GDB/GCC compile function pointers [Re: [PATCH v4 00/14] let gdb reuse gcc's C compiler] Jan Kratochvil
2014-12-12 21:51 ` obsolete: " Jan Kratochvil
2014-12-12 14:40 ` [PATCH v4 00/14] let gdb reuse gcc's C compiler Pedro Alves
2014-12-12 21:46 ` [commit all 14 parts] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219192457.GA28791@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ktietz@redhat.com \
--cc=palves@redhat.com \
--cc=sellcey@imgtec.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).