From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31742 invoked by alias); 7 Jan 2015 07:03:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31723 invoked by uid 89); 7 Jan 2015 07:03:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 07 Jan 2015 07:03:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9476E116528; Wed, 7 Jan 2015 02:03:41 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id zgRlVtdTMfPb; Wed, 7 Jan 2015 02:03:41 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 23A47116527; Wed, 7 Jan 2015 02:03:41 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 19BDA4100E; Wed, 7 Jan 2015 11:03:37 +0400 (RET) Date: Wed, 07 Jan 2015 07:03:00 -0000 From: Joel Brobecker To: Siva Chandra Cc: gdb-patches Subject: Re: [PATCH] Remove unwanted spaces when looking up builtin types Message-ID: <20150107070337.GO5445@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00094.txt.bz2 > +/* Return 1 if C is a whitespace character, 0 otherwise. */ > + > +static int > +whitespace_p (const char c) > +{ > + if (c == ' ' || c == '\n' || c == '\t') > + return 1; > + else > + return 0; Why not using isspace directly? Apologies if this was explained before, but then, a comment would be helpful, and maybe a more specific function name. My first reaction to this kind of routine was that this should be in one of our "utils" files, so as to allow other parts of the code to use it as well. -- Joel