From: Joel Brobecker <brobecker@adacore.com>
To: Patrick Palka <patrick@parcs.ath.cx>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [RFC] Don't propagate our current terminal state to the inferior
Date: Wed, 07 Jan 2015 14:56:00 -0000 [thread overview]
Message-ID: <20150107145602.GA419@adacore.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1501070906170.2325@idea>
[-- Attachment #1: Type: text/plain, Size: 801 bytes --]
> gdb/ChangeLog:
>
> * terminal.h (set_initial_gdb_ttystate): Declare.
> * inflow.c (initial_gdb_ttystate): New static variable.
> (set_initial_gdb_ttystate): New setter.
> (child_terminal_init_with_pgrp): Copy initial_gdb_ttystate
> instead of our current terminal state.
> * top.c (gdb_init): Call set_initial_gdb_ttystate.
Small nit that I noticed just as I glanced at the patch...
> +/* Set the initial tty state that is to be inherited by new inferiors. */
> +void
> +set_initial_gdb_ttystate (void)
> +{
We ask that an empty line between the function's documentation
and its implementation be inserted.
I have pushed the attached patch as obvious...
gdb/ChangeLog:
* inflow.c (set_initial_gdb_ttystate): Add empty line after
comment documenting function.
--
Joel
[-- Attachment #2: 0001-Empty-line-after-comment-documenting-set_initial_gdb.patch --]
[-- Type: text/x-diff, Size: 1151 bytes --]
From ea42d6f8d1e24403e533e5dfea18e94c47ac534b Mon Sep 17 00:00:00 2001
From: Joel Brobecker <brobecker@adacore.com>
Date: Wed, 7 Jan 2015 18:49:49 +0400
Subject: [PATCH] Empty line after comment documenting
set_initial_gdb_ttystate.
gdb/ChangeLog:
* inflow.c (set_initial_gdb_ttystate): Add empty line after
comment documenting function.
---
gdb/ChangeLog | 5 +++++
gdb/inflow.c | 1 +
2 files changed, 6 insertions(+)
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 6477dc1..e9b0377 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-01-07 Joel Brobecker <brobecker@adacore.com>
+
+ * inflow.c (set_initial_gdb_ttystate): Add empty line after
+ comment documenting function.
+
2015-01-07 Patrick Palka <patrick@parcs.ath.cx>
* terminal.h (set_initial_gdb_ttystate): Declare.
diff --git a/gdb/inflow.c b/gdb/inflow.c
index 3c121a3..4c81a68 100644
--- a/gdb/inflow.c
+++ b/gdb/inflow.c
@@ -161,6 +161,7 @@ show_interactive_mode (struct ui_file *file, int from_tty,
}
/* Set the initial tty state that is to be inherited by new inferiors. */
+
void
set_initial_gdb_ttystate (void)
{
--
1.9.1
next prev parent reply other threads:[~2015-01-07 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-22 20:39 Patrick Palka
2014-11-23 10:25 ` Joel Brobecker
2015-01-07 13:09 ` Patrick Palka
2015-01-07 13:39 ` Pedro Alves
2015-01-07 14:13 ` Patrick Palka
2015-01-07 14:56 ` Joel Brobecker [this message]
2015-01-07 14:57 ` Joel Brobecker
2015-01-07 15:18 ` Patrick Palka
2015-01-07 21:44 ` Patrick Palka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107145602.GA419@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).