From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6687 invoked by alias); 7 Jan 2015 14:56:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 6674 invoked by uid 89); 7 Jan 2015 14:56:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 07 Jan 2015 14:56:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7F210116557; Wed, 7 Jan 2015 09:56:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kJJH5nY0Qqh0; Wed, 7 Jan 2015 09:56:05 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 1AFCF116448; Wed, 7 Jan 2015 09:56:05 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3BA324100E; Wed, 7 Jan 2015 18:56:02 +0400 (RET) Date: Wed, 07 Jan 2015 14:56:00 -0000 From: Joel Brobecker To: Patrick Palka Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [RFC] Don't propagate our current terminal state to the inferior Message-ID: <20150107145602.GA419@adacore.com> References: <1416688748-20448-1-git-send-email-patrick@parcs.ath.cx> <54AD3716.7070209@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00113.txt.bz2 --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 801 > gdb/ChangeLog: > > * terminal.h (set_initial_gdb_ttystate): Declare. > * inflow.c (initial_gdb_ttystate): New static variable. > (set_initial_gdb_ttystate): New setter. > (child_terminal_init_with_pgrp): Copy initial_gdb_ttystate > instead of our current terminal state. > * top.c (gdb_init): Call set_initial_gdb_ttystate. Small nit that I noticed just as I glanced at the patch... > +/* Set the initial tty state that is to be inherited by new inferiors. */ > +void > +set_initial_gdb_ttystate (void) > +{ We ask that an empty line between the function's documentation and its implementation be inserted. I have pushed the attached patch as obvious... gdb/ChangeLog: * inflow.c (set_initial_gdb_ttystate): Add empty line after comment documenting function. -- Joel --RnlQjJ0d97Da+TV1 Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-Empty-line-after-comment-documenting-set_initial_gdb.patch" Content-length: 1152 >From ea42d6f8d1e24403e533e5dfea18e94c47ac534b Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Wed, 7 Jan 2015 18:49:49 +0400 Subject: [PATCH] Empty line after comment documenting set_initial_gdb_ttystate. gdb/ChangeLog: * inflow.c (set_initial_gdb_ttystate): Add empty line after comment documenting function. --- gdb/ChangeLog | 5 +++++ gdb/inflow.c | 1 + 2 files changed, 6 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 6477dc1..e9b0377 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2015-01-07 Joel Brobecker + + * inflow.c (set_initial_gdb_ttystate): Add empty line after + comment documenting function. + 2015-01-07 Patrick Palka * terminal.h (set_initial_gdb_ttystate): Declare. diff --git a/gdb/inflow.c b/gdb/inflow.c index 3c121a3..4c81a68 100644 --- a/gdb/inflow.c +++ b/gdb/inflow.c @@ -161,6 +161,7 @@ show_interactive_mode (struct ui_file *file, int from_tty, } /* Set the initial tty state that is to be inherited by new inferiors. */ + void set_initial_gdb_ttystate (void) { -- 1.9.1 --RnlQjJ0d97Da+TV1--