From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15292 invoked by alias); 10 Jan 2015 04:30:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12038 invoked by uid 89); 10 Jan 2015 04:30:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 10 Jan 2015 04:30:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 253FC11638A; Fri, 9 Jan 2015 23:30:07 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id QcmE4nahUPJa; Fri, 9 Jan 2015 23:30:07 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D183C116385; Fri, 9 Jan 2015 23:30:05 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 3504E48E89; Sat, 10 Jan 2015 08:30:02 +0400 (RET) Date: Sat, 10 Jan 2015 04:30:00 -0000 From: Joel Brobecker To: Chen Gang S Cc: Pedro Alves , sellcey@imgtec.com, Jan Kratochvil , "Maciej W. Rozycki" , gdb-patches@sourceware.org, Yao Qi Subject: Re: [Patch] Fix build problem with system call in compile/compile.c Message-ID: <20150110043002.GR5445@adacore.com> References: <54AD8A76.9010702@redhat.com> <20150108211229.GA5634@host2.jankratochvil.net> <1420755123.2630.21.camel@ubuntu-sellcey> <54AF1118.2070707@redhat.com> <1420762209.2630.27.camel@ubuntu-sellcey> <54AF50E4.3080901@sunrus.com.cn> <54AFA92C.8010108@redhat.com> <54AFB275.9060803@sunrus.com.cn> <54B04125.4050802@sunrus.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54B04125.4050802@sunrus.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00252.txt.bz2 > Excuse me, I am not quite familiar with the patch apply working flow for > binutils/gdb, it seems each patch can only have one 'Signed-of-by' for > it (do not like Linux kernel or QEMU, can have multiple 'Signed-of-by'). > > For me, this patch need multiple 'Signed-of-by': I start the patch, and > Pedro Alves give a very necessary improvement (or it will introduce a > new bug, which is not recognized quite obviously by others). I know you've answered your own question about your patch in particular, but I wanted to clarify a couple of things. About "can only have one 'Signed-off-by'": We do not use git's sign-off (at least, not at the moment). As you know, there is an approval process through this mailing list which is used instead, but who actually approves the patch is not recorded in the git commit. However, the approver is not the same thing at the author, or the group of authors. If you are the sole author of a patch, and I request a few small changes that you make, and then it gets approved, you are still the sole author of those changes. Hence your name remains the only name listed in the corresponding ChangeLog entries. There is a small exception where a reviewer contributes significant ideas towards the final patch, or even contributes pieces of it, in which case the reviewer now also becomes co-author, in which case his name gets added to the corresponding ChangeLog entries. > If what I said above is correct, one way maybe, apply my original patch > firstly, then apply the fix patch by Pedro Alves. I am not quite sure > whether this way is suitable or not, though. About that: We avoid that approach, because it introduces a commit where we know there is an issue. Although the issue is supposed to get fixed right after, it still isn't great in the context of "git bisect" for instance. -- Joel