From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14722 invoked by alias); 11 Jan 2015 14:51:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14707 invoked by uid 89); 11 Jan 2015 14:51:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sun, 11 Jan 2015 14:51:23 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0BEpJE7027045 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 11 Jan 2015 09:51:19 -0500 Received: from host2.jankratochvil.net (ovpn-116-51.ams2.redhat.com [10.36.116.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t0BEpFIx018978 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 11 Jan 2015 09:51:17 -0500 Date: Sun, 11 Jan 2015 14:51:00 -0000 From: Jan Kratochvil To: Yao Qi Cc: gdb-patches@sourceware.org, Sasha Smundak Subject: Re: [testsuite patch] Fix new FAIL: py-frame.exp: test Frame.read_register(rip) Message-ID: <20150111145114.GA11550@host2.jankratochvil.net> References: <20150107143820.GA1482@host2.jankratochvil.net> <87r3v1s9ld.fsf@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline In-Reply-To: <87r3v1s9ld.fsf@codesourcery.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00274.txt.bz2 --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-length: 283 On Sun, 11 Jan 2015 14:58:06 +0100, Yao Qi wrote: > With your patch applied, this test is skipped on 'x86_64 -m32'. I > prefer to increasing the test coverage, so how about extending the test > for 'x86_64 -m32'? I mean test Frame.read_register(eip)... OK this way? Thanks, Jan --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename=1 Content-length: 1070 gdb/testsuite/ 2015-01-11 Jan Kratochvil * gdb.python/py-frame.exp (test Frame.read_register(rip)): Use is_amd64_regs_target and is_x86_like_target. diff --git a/gdb/testsuite/gdb.python/py-frame.exp b/gdb/testsuite/gdb.python/py-frame.exp index bf2e1ce..33fdbe5 100644 --- a/gdb/testsuite/gdb.python/py-frame.exp +++ b/gdb/testsuite/gdb.python/py-frame.exp @@ -105,9 +105,15 @@ gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.pc()))" \ " = True" \ "test Frame.read_register(pc)" -# On x86-64, PC is in $rip register. -if {[istarget x86_64-*]} { - gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.read_register('rip')))" \ +# Test arch-specific register name. +set pc "" +if {[is_amd64_regs_target]} { + set pc "rip" +} elseif {[is_x86_like_target]} { + set pc "eip" +} +if { $pc != "" } { + gdb_test "python print ('result = %s' % (f0.read_register('pc') == f0.read_register('$pc')))" \ " = True" \ - "test Frame.read_register(rip)" + "test Frame.read_register($pc)" } --SLDf9lqlvOQaIe6s--