From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18629 invoked by alias); 12 Jan 2015 09:57:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18617 invoked by uid 89); 12 Jan 2015 09:57:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 12 Jan 2015 09:57:22 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5ADE21162E2; Mon, 12 Jan 2015 04:57:20 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8pz-x3c5VqyC; Mon, 12 Jan 2015 04:57:20 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id D1D041162E1; Mon, 12 Jan 2015 04:57:19 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id EB64648E89; Mon, 12 Jan 2015 13:57:11 +0400 (RET) Date: Mon, 12 Jan 2015 09:57:00 -0000 From: Joel Brobecker To: Jan Kratochvil Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [patch] Fix jit-reader.h for multilib Message-ID: <20150112095711.GZ5445@adacore.com> References: <20150107173634.GA13295@host2.jankratochvil.net> <87387htths.fsf@codesourcery.com> <20150111131353.GA9107@host2.jankratochvil.net> <87iogcsp6m.fsf@codesourcery.com> <20150112084206.GA27188@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150112084206.GA27188@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00294.txt.bz2 > As I said this patch may not affect much/any other distros because > * at least Debian does not ship jit-reader.h at all > * other distros may not consider GDB as a multilib package I don't think the problem would be specific to Fedora - it is possible that other distros might benefit from the fix as well. The only thing that gave me pause was the relatively strange fix, and the fact that I didn't really understand the issue, and therefore didn't understand the fix. I don't know much about jit-reader.h, and the impact of the fix, but I have a feeling that it would beneficial to others and therefore should be considered for inclusion. -- Joel