Re: [PATCH 3/3 v2] Implement completion limiting

[Gary Benson <gbenson@redhat.com>]

Doug Evans wrote:
> On Sat, Jan 10, 2015 at 1:23 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> > > From: Doug Evans <dje@google.com>
> > > Date: Fri, 9 Jan 2015 18:32:01 -0800
> > > Cc: gdb-patches@sourceware.org
> > >
> > > +If the number of possible completions is large, @value{GDBN} will
> > > +print as much of the list as it has collected, as well as a message
> > > +indicating that the list may be truncated.
> > > +
> > > +@smallexample
> > > +(@value{GDBP}) b m@key{TAB}@key{TAB}
> > > +m *** List may be truncated, max-completions reached. ***
> > > +main
> > > +<... the rest of the possible completions ...>
> > > +(@value{GDBP}) b m
> >
> > Doesn't the "list may be truncated" message scrolls off the
> > screen, if the list is long enough?  If so, wouldn't it be better
> > to display that message at the end instead, saying something like
> >
> >   (More completions follow; max-completions exceeded.)
> 
> If the user sets a bad height, or if pagination is turned off,
> possibly.
> 
> I can put it at the end.

I'd prefer it at the end.

Cheers,
Gary

-- 
http://gbenson.net/