Re: [PATCH 2/2] Move code to disable ASR to nat/

["Ulrich Weigand" <uweigand@de.ibm.com>]

Sergio Durigan Junior wrote:

> This patch moves the shared code present on
> gdb/linux-nat.c:linux_nat_create_inferior and
> gdb/gdbserver/linux-low.c:linux_create_inferior to
> nat/linux-personality.c.  This code is responsible for disabling
> address space randomization based on user setting, and using
> <sys/personality.h> to do that.  I decided to put the prototype of the
> maybe_disable_address_space_randomization on nat/linux-osdata.h
> because it seemed the best place to put it.

This breaks building on my RHEL 5 machine:

/home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c: In function 'maybe_disable_address_space_randomization':
/home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: 'ADDR_NO_RANDOMIZE' undeclared (first use in this function)
/home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: (Each undeclared identifier is reported only once
/home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: for each function it appears in.)

It looks like this is because you replaced:
> -# if !HAVE_DECL_ADDR_NO_RANDOMIZE
by:
> +# ifndef HAVE_DECL_ADDR_NO_RANDOMIZE

but config.h on my machine without ADDR_NO_RANDOMIZE contains:
#define HAVE_DECL_ADDR_NO_RANDOMIZE 0

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com