From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31878 invoked by alias); 16 Jan 2015 15:39:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31812 invoked by uid 89); 16 Jan 2015 15:38:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e39.co.us.ibm.com Received: from e39.co.us.ibm.com (HELO e39.co.us.ibm.com) (32.97.110.160) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 16 Jan 2015 15:38:57 +0000 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Jan 2015 08:38:55 -0700 Received: from d03dlp01.boulder.ibm.com (9.17.202.177) by e39.co.us.ibm.com (192.168.1.139) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 16 Jan 2015 08:38:53 -0700 Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id A57CC1FF0021 for ; Fri, 16 Jan 2015 08:30:04 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0GFdLaT45350926 for ; Fri, 16 Jan 2015 08:39:21 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0GFco7B021821 for ; Fri, 16 Jan 2015 08:38:51 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t0GFclYf021559; Fri, 16 Jan 2015 08:38:47 -0700 Message-Id: <201501161538.t0GFclYf021559@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 16 Jan 2015 16:38:46 +0100 Subject: Re: [PATCH 2/2] Move code to disable ASR to nat/ To: sergiodj@redhat.com (Sergio Durigan Junior) Date: Fri, 16 Jan 2015 15:39:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), palves@redhat.com (Pedro Alves), gbenson@redhat.com (Gary Benson), sergiodj@redhat.com (Sergio Durigan Junior) In-Reply-To: <1420841943-24290-3-git-send-email-sergiodj@redhat.com> from "Sergio Durigan Junior" at Jan 09, 2015 05:19:03 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15011615-0033-0000-0000-0000035AB348 X-SW-Source: 2015-01/txt/msg00458.txt.bz2 Sergio Durigan Junior wrote: > This patch moves the shared code present on > gdb/linux-nat.c:linux_nat_create_inferior and > gdb/gdbserver/linux-low.c:linux_create_inferior to > nat/linux-personality.c. This code is responsible for disabling > address space randomization based on user setting, and using > to do that. I decided to put the prototype of the > maybe_disable_address_space_randomization on nat/linux-osdata.h > because it seemed the best place to put it. This breaks building on my RHEL 5 machine: /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c: In function 'maybe_disable_address_space_randomization': /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: 'ADDR_NO_RANDOMIZE' undeclared (first use in this function) /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: (Each undeclared identifier is reported only once /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: for each function it appears in.) It looks like this is because you replaced: > -# if !HAVE_DECL_ADDR_NO_RANDOMIZE by: > +# ifndef HAVE_DECL_ADDR_NO_RANDOMIZE but config.h on my machine without ADDR_NO_RANDOMIZE contains: #define HAVE_DECL_ADDR_NO_RANDOMIZE 0 Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com