From: Joel Brobecker <brobecker@adacore.com>
To: Richard Henderson <rth@redhat.com>
Cc: Binutils <binutils@sourceware.org>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: Experimental branches
Date: Sat, 17 Jan 2015 04:17:00 -0000 [thread overview]
Message-ID: <20150117041704.GA4629@adacore.com> (raw)
In-Reply-To: <54B95B9A.3030408@redhat.com>
> > That one is actually intentional. I really think that those diffs
> > are really useful - at least to me - and this was discussed a bit
> > when I made the proposal to switch to the new hooks. Do you think
> > they are a problem?
>
> Are they really useful? There's always the link at the top of the
> commit email that allows you to view the diff.
I can only speak personally, but I think they are. I usually take
a glance at the diffs that actually went in, and I've been catching
a few little things here and there. Having to click on links makes that
clunky enough that I just don't do it; this is compounded by the fact
that I use a text-based mail-reader. I'm also regularly offline as well
when reading emails (which I have downloaded onto my computer). Having
the diff in the email is also the difference between looking at it and
not.
Despite all that, I do not have a necessarily strong opinion about
this. Unless we actually find that the diffs are causing trouble,
I'd like to give the diffs a try. But if people want to go back,
then I'll make that happen.
--
Joel
next prev parent reply other threads:[~2015-01-17 4:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHACq4rzgyE-2cM=UV30-1MWKHsWqwF1QdtuAujgYzFJ=8Y08A@mail.gmail.com>
2014-12-23 13:27 ` Joel Brobecker
2014-12-23 17:38 ` Cary Coutant
2014-12-23 17:42 ` H.J. Lu
2014-12-23 18:08 ` Joel Brobecker
2014-12-23 18:21 ` Cary Coutant
2014-12-23 18:26 ` H.J. Lu
2014-12-24 0:20 ` Joel Brobecker
2015-01-15 21:56 ` Cary Coutant
2015-01-15 22:48 ` H.J. Lu
2015-01-15 23:04 ` Cary Coutant
2015-01-15 23:20 ` H.J. Lu
2015-01-16 18:41 ` Richard Henderson
2015-01-16 19:07 ` Cary Coutant
2015-01-16 19:26 ` Doug Evans
2015-01-16 3:14 ` Joel Brobecker
2015-01-15 23:57 ` Alan Modra
2015-01-16 3:19 ` Joel Brobecker
2015-01-16 18:42 ` Richard Henderson
2015-01-17 4:17 ` Joel Brobecker [this message]
2015-01-17 3:24 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150117041704.GA4629@adacore.com \
--to=brobecker@adacore.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).