From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16802 invoked by alias); 17 Jan 2015 04:17:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16773 invoked by uid 89); 17 Jan 2015 04:17:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Sat, 17 Jan 2015 04:17:12 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 65E3611653C; Fri, 16 Jan 2015 23:17:10 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OjIGnE8SiZRI; Fri, 16 Jan 2015 23:17:10 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id EEAE011651C; Fri, 16 Jan 2015 23:17:09 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id AF50348E8B; Sat, 17 Jan 2015 08:17:04 +0400 (RET) Date: Sat, 17 Jan 2015 04:17:00 -0000 From: Joel Brobecker To: Richard Henderson Cc: Binutils , gdb-patches Subject: Re: Experimental branches Message-ID: <20150117041704.GA4629@adacore.com> References: <20141223180802.GP12884@adacore.com> <20141224002022.GQ12884@adacore.com> <20150115235652.GU23768@bubble.grove.modra.org> <20150116031811.GR8167@adacore.com> <54B95B9A.3030408@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54B95B9A.3030408@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00491.txt.bz2 > > That one is actually intentional. I really think that those diffs > > are really useful - at least to me - and this was discussed a bit > > when I made the proposal to switch to the new hooks. Do you think > > they are a problem? > > Are they really useful? There's always the link at the top of the > commit email that allows you to view the diff. I can only speak personally, but I think they are. I usually take a glance at the diffs that actually went in, and I've been catching a few little things here and there. Having to click on links makes that clunky enough that I just don't do it; this is compounded by the fact that I use a text-based mail-reader. I'm also regularly offline as well when reading emails (which I have downloaded onto my computer). Having the diff in the email is also the difference between looking at it and not. Despite all that, I do not have a necessarily strong opinion about this. Unless we actually find that the diffs are causing trouble, I'd like to give the diffs a try. But if people want to go back, then I'll make that happen. -- Joel