From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19955 invoked by alias); 19 Jan 2015 19:16:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19937 invoked by uid 89); 19 Jan 2015 19:16:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e34.co.us.ibm.com Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.152) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 19 Jan 2015 19:16:48 +0000 Received: from /spool/local by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 19 Jan 2015 12:16:46 -0700 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 19 Jan 2015 12:16:44 -0700 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 9E2603E4003F for ; Mon, 19 Jan 2015 12:15:13 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0JJGutO34275434 for ; Mon, 19 Jan 2015 12:16:56 -0700 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0JJGi0H010159 for ; Mon, 19 Jan 2015 12:16:44 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with SMTP id t0JJGfjK009935; Mon, 19 Jan 2015 12:16:42 -0700 Message-Id: <201501191916.t0JJGfjK009935@d03av02.boulder.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 19 Jan 2015 20:16:41 +0100 Subject: Re: [PATCH][commit] Fix regression on RHEL-5 systems (was: Re: [PATCH 2/2] Move code to disable ASR to nat/) To: sergiodj@redhat.com (Sergio Durigan Junior) Date: Mon, 19 Jan 2015 19:16:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches), palves@redhat.com (Pedro Alves), gbenson@redhat.com (Gary Benson) In-Reply-To: <871tmu8ygd.fsf@redhat.com> from "Sergio Durigan Junior" at Jan 16, 2015 11:47:14 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15011919-0017-0000-0000-000008116813 X-SW-Source: 2015-01/txt/msg00533.txt.bz2 Sergio Durigan Junior wrote: > On Friday, January 16 2015, Ulrich Weigand wrote: > > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c: In function 'maybe_disable_address_space_randomization': > > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: 'ADDR_NO_RANDOMIZE' undeclared (first use in this function) > > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: (Each undeclared identifier is reported only once > > /home/uweigand/dailybuild/spu-tc-2015-01-15/binutils-gdb-head/binutils-gdb/gdb/nat/linux-personality.c:80: error: for each function it appears in.) > > Ops. Thanks for letting me know, Ulrich. > > > It looks like this is because you replaced: > >> -# if !HAVE_DECL_ADDR_NO_RANDOMIZE > > by: > >> +# ifndef HAVE_DECL_ADDR_NO_RANDOMIZE > > > > but config.h on my machine without ADDR_NO_RANDOMIZE contains: > > #define HAVE_DECL_ADDR_NO_RANDOMIZE 0 > > I took the liberty to go ahead and push the following patch as obvious. > Please let me know if there is anything else needed. Thanks, this does fix the problem for me. Bye, Ulrich -- Dr. Ulrich Weigand GNU/Linux compilers and toolchain Ulrich.Weigand@de.ibm.com