From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patchv3] Sort threads for thread apply all (bt)
Date: Thu, 22 Jan 2015 19:23:00 -0000 [thread overview]
Message-ID: <CADPb22T1bCqnFU4iba=PBtHPhexao8ZztBDz=SCARHKubrc5qA@mail.gmail.com> (raw)
Message-ID: <20150122192300.ZWIBfqrYYzqzoHlVVzGXdfzOcVNwAUpED9oMPj-MnVg@z> (raw)
In-Reply-To: <20150122184655.GA15064@host2.jankratochvil.net>
On Thu, Jan 22, 2015 at 10:46 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:
> ...
>> This triggers my "passing parameters as global variables" alarm,
>> and while one could instead have two different functions,
>
> I believe qsort_r() is more appropriate, using two different functions I would
> feel rather as a workaround of missing qsort_r(). But I guess (I cannot easily
> test due to missing slaves and no patch testing feature in Sergio's Buildbot
> yet) some of the supported platforms do not provide qsort_r() so it would need
> a new gdb/gnulib/ module. But at least one of my gdb/gnulib/ patches is still
> under review so it would create dependency between unrelated patchsets.
I think you're splitting hairs here.
> + if (cmd != NULL && (check_for_argument (&cmd, "-ascending", strlen ("-asc"))))
strlen ("-ascending")
Also, remove the extra parens around check_for_argument?
next prev parent reply other threads:[~2015-01-22 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 18:33 [patch] " Jan Kratochvil
2015-01-15 19:29 ` Doug Evans
2015-01-16 23:38 ` [patchv2] " Jan Kratochvil
2015-01-22 0:26 ` Doug Evans
2015-01-22 11:18 ` Pedro Alves
2015-01-22 16:43 ` Jan Kratochvil
2015-01-22 17:07 ` Pedro Alves
2015-01-22 17:18 ` Jan Kratochvil
2015-01-22 18:09 ` Doug Evans
2015-01-22 18:13 ` Jan Kratochvil
2015-01-22 18:49 ` [patchv3] " Jan Kratochvil
2015-01-22 18:52 ` Eli Zaretskii
2015-01-22 19:24 ` [patchv4] " Jan Kratochvil
2015-01-22 19:34 ` Doug Evans
2015-01-22 20:08 ` Doug Evans
2015-01-22 21:15 ` [commit] [patchv5] " Jan Kratochvil
2015-01-22 20:52 ` [patchv4] " Eli Zaretskii
2015-01-22 19:10 ` Doug Evans [this message]
2015-01-22 19:23 ` [patchv3] " Doug Evans
2015-01-22 19:24 ` [patchv5] " Jan Kratochvil
2015-01-22 20:37 ` [patchv3] " Doug Evans
2015-01-17 20:59 ` [patch] Print current thread after loading a core file [Re: [patch] Sort threads for thread apply all (bt)] Jan Kratochvil
2015-01-22 0:36 ` Doug Evans
2015-01-22 18:36 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADPb22T1bCqnFU4iba=PBtHPhexao8ZztBDz=SCARHKubrc5qA@mail.gmail.com' \
--to=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).