From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang S <gang.chen@sunrus.com.cn>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v5] gdb/hppa-tdep.c: Fix logical working flow issues and check additional store instructions
Date: Fri, 23 Jan 2015 07:54:00 -0000 [thread overview]
Message-ID: <20150123073154.GS4041@adacore.com> (raw)
In-Reply-To: <54C0F692.3010106@sunrus.com.cn>
> At present, the related code are changed a little (fix gcc-5 warning).
> So need change the patch a little, but have no effect with the final
> applied code.
OK. The expectation, when you push something that's different from
what you had reviewed is to send the final version of the patch on
this list. I find this is a little less important, now that we have
diffs in gdb-cvs emails, as well as now that we use git, but it's
part of our procedures; so would you mind please sending a copy here?
Thank you,
--
Joel
next prev parent reply other threads:[~2015-01-23 7:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 21:02 Chen Gang
2014-12-20 17:26 ` Joel Brobecker
2014-12-20 21:07 ` Chen Gang
2015-01-21 10:46 ` Chen Gang S
2015-01-21 10:57 ` Joel Brobecker
2015-01-22 13:09 ` Chen Gang S
2015-01-23 7:54 ` Joel Brobecker [this message]
2015-01-23 10:04 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150123073154.GS4041@adacore.com \
--to=brobecker@adacore.com \
--cc=gang.chen@sunrus.com.cn \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).