public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang S <gang.chen@sunrus.com.cn>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().
Date: Thu, 29 Jan 2015 07:03:00 -0000	[thread overview]
Message-ID: <20150129044911.GB5193@adacore.com> (raw)
In-Reply-To: <54C8CBC8.90102@sunrus.com.cn>

[binutils does not need to be copied in this case, as you're only
touching files in the simulator, which is part of the GDB project]

> 2015-01-28  Chen Gang <gang.chen.5i5j@gmail.com>
> 
> 	* common/sim-options.c (sim_args_command): Call freeargv() when
> 	failure occurs.
> 	* mcore/interp.c (sim_do_command): Call freeargv() before return.
> 	* microblaze/interp.c (sim_do_command): Call freeargv() before
> 	return.

Small procedural request, Chen. Those 3 changes are pretty much
independent, so it's highly preferable to submit them separately.
This has a number of advantages: We can review each one of them
individually, with possibly different reviewers, and that makes
tracking of which part has been reviewed a lot easier. Also, by
having them submitted separately, you can have one patch per piece,
which means that if one patch turns out to be incorrect, we can
easily revert just that patch using git, rather than doing a semi-
revert by hand.

-- 
Joel

  parent reply	other threads:[~2015-01-29  4:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-28 15:53 Chen Gang S
2015-01-28 20:43 ` Michael Eager
2015-01-29  4:53   ` Chen Gang S
2015-01-29  5:01     ` Michael Eager
2015-01-29  5:11       ` Chen Gang S
2015-02-17 10:36     ` Mike Frysinger
2015-01-29  7:03 ` Joel Brobecker [this message]
2015-01-29  7:28   ` Chen Gang S
2015-01-31  8:59 Chen Gang S
2015-01-31 11:56 Chen Gang S
2015-01-31 18:46 ` Michael Eager
2015-02-02 19:38   ` Chen Gang S
2015-02-03  2:50     ` Joel Brobecker
2015-02-03  9:58       ` Chen Gang S
2015-02-17 10:34 ` Mike Frysinger
2015-02-17 23:10   ` Chen Gang S
2015-02-18  0:22     ` Mike Frysinger
2015-02-19  0:34       ` Chen Gang S
2015-02-19 15:53         ` Michael Eager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150129044911.GB5193@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gang.chen@sunrus.com.cn \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).