From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5380 invoked by alias); 29 Jan 2015 04:49:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5315 invoked by uid 89); 29 Jan 2015 04:49:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 29 Jan 2015 04:49:19 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5906C11668D; Wed, 28 Jan 2015 23:49:17 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id u1H6gZzg0bj5; Wed, 28 Jan 2015 23:49:17 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 12A64116283; Wed, 28 Jan 2015 23:49:16 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E7195491BD; Thu, 29 Jan 2015 08:49:11 +0400 (RET) Date: Thu, 29 Jan 2015 07:03:00 -0000 From: Joel Brobecker To: Chen Gang S Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). Message-ID: <20150129044911.GB5193@adacore.com> References: <54C8CBC8.90102@sunrus.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54C8CBC8.90102@sunrus.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00746.txt.bz2 [binutils does not need to be copied in this case, as you're only touching files in the simulator, which is part of the GDB project] > 2015-01-28 Chen Gang > > * common/sim-options.c (sim_args_command): Call freeargv() when > failure occurs. > * mcore/interp.c (sim_do_command): Call freeargv() before return. > * microblaze/interp.c (sim_do_command): Call freeargv() before > return. Small procedural request, Chen. Those 3 changes are pretty much independent, so it's highly preferable to submit them separately. This has a number of advantages: We can review each one of them individually, with possibly different reviewers, and that makes tracking of which part has been reviewed a lot easier. Also, by having them submitted separately, you can have one patch per piece, which means that if one patch turns out to be incorrect, we can easily revert just that patch using git, rather than doing a semi- revert by hand. -- Joel