From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/6] Constify some parameters in the varobj code
Date: Fri, 30 Jan 2015 09:03:00 -0000 [thread overview]
Message-ID: <20150130033326.GL5193@adacore.com> (raw)
In-Reply-To: <1422559716-5480-4-git-send-email-simon.marchi@ericsson.com>
> I did that to make sure there was no other cases like the one fixed in
> the previous patch. I don't think it can hurt.
Agreed.
> gdb/ChangeLog:
>
> * ada-varobj.c (ada_number_of_children): Constify struct varobj *
> parameter.
> (ada_name_of_variable): Same.
> (ada_path_expr_of_child): Same.
> (ada_value_of_variable): Same.
> (ada_value_is_changeable_p): Same.
> (ada_value_has_mutated): Same.
> * c-varobj.c (varobj_is_anonymous_child): Same.
> (c_is_path_expr_parent): Same.
> (c_number_of_children): Same.
> (c_name_of_variable): Same.
> (c_path_expr_of_child): Same.
> (get_type): Same.
> (c_value_of_variable): Same.
> (cplus_number_of_children): Same.
> (cplus_name_of_variable): Same.
> (cplus_path_expr_of_child): Same.
> (cplus_value_of_variable): Same.
> * jv-varobj.c (java_number_of_children): Same.
> (java_name_of_variable): Same.
> (java_path_expr_of_child): Same.
> (java_value_of_variable): Same.
> * varobj.c (number_of_children): Same.
> (name_of_variable): Same.
> (is_root_p): Same.
> (varobj_ensure_python_env): Same.
> (varobj_get_objname): Same.
> (varobj_get_expression): Same.
> (varobj_get_display_format): Same.
> (varobj_get_display_hint): Same.
> (varobj_has_more): Same.
> (varobj_get_thread_id): Same.
> (varobj_get_frozen): Same.
> (dynamic_varobj_has_child_method): Same.
> (varobj_get_gdb_type): Same.
> (is_path_expr_parent): Same.
> (varobj_default_is_path_expr_parent): Same.
> (varobj_get_language): Same.
> (varobj_get_attributes): Same.
> (varobj_is_dynamic_p): Same.
> (varobj_get_child_range): Same.
> (varobj_value_has_mutated): Same.
> (varobj_get_value_type): Same.
> (number_of_children): Same.
> (name_of_variable): Same.
> (check_scope): Same.
> (varobj_editable_p): Same.
> (varobj_value_is_changeable_p): Same.
> (varobj_floating_p): Same.
> (varobj_default_value_is_changeable_p): Same.
> * varobj.h (struct lang_varobj_ops): Consitfy some struct varobj *
> parameters.
> (varobj_get_objname): Constify struct varobj * parameter.
> (varobj_get_expression): Same.
> (varobj_get_thread_id): Same.
> (varobj_get_frozen): Same.
> (varobj_get_child_range): Same.
> (varobj_get_display_hint): Same.
> (varobj_get_gdb_type): Same.
> (varobj_get_language): Same.
> (varobj_get_attributes): Same.
> (varobj_editable_p): Same.
> (varobj_floating_p): Same.
> (varobj_has_more): Same.
> (varobj_is_dynamic_p): Same.
> (varobj_ensure_python_env): Same.
> (varobj_default_value_is_changeable_p): Same.
> (varobj_value_is_changeable_p): Same.
> (varobj_get_value_type): Same.
> (varobj_is_anonymous_child): Same.
> (varobj_value_get_print_value): Same.
> (varobj_default_is_path_expr_parent): Same.
Sorry you had to write such as long ChangeLog entry. CL can be useful
at times, but really a timewaster at others :-(.
The patch looks pretty good to me, with a few corrections to avoid
some lines that became too long. Pre-approved with those adjustments.
--
Joel
next prev parent reply other threads:[~2015-01-30 3:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 19:29 [PATCH 1/6] Free results of varobj_get_expression Simon Marchi
2015-01-30 1:56 ` [PATCH 3/6] Set varobj->path_expr in varobj_get_path_expr Simon Marchi
2015-01-30 18:55 ` Joel Brobecker
2015-01-30 22:58 ` Simon Marchi
2015-01-30 3:13 ` [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops Simon Marchi
2015-01-30 8:19 ` Joel Brobecker
2015-01-30 20:10 ` Simon Marchi
2015-01-31 20:06 ` Joel Brobecker
2015-02-02 18:18 ` Simon Marchi
2015-01-30 3:28 ` [PATCH 6/6] Fix varobj_delete comment Simon Marchi
2015-01-30 17:04 ` Joel Brobecker
2015-01-31 3:20 ` Simon Marchi
2015-01-30 3:33 ` [PATCH 5/6] Mention that create_child takes ownership of the allocated name Simon Marchi
2015-01-30 16:41 ` Joel Brobecker
2015-01-31 1:14 ` Simon Marchi
2015-01-30 3:35 ` [PATCH 4/6] Constify some parameters in the varobj code Simon Marchi
2015-01-30 9:03 ` Joel Brobecker [this message]
2015-01-30 22:59 ` Simon Marchi
2015-02-03 16:55 ` Pedro Alves
2015-02-03 18:07 ` Simon Marchi
2015-01-30 3:40 ` [PATCH 1/6] Free results of varobj_get_expression Joel Brobecker
2015-01-30 22:57 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130033326.GL5193@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).