From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Free results of varobj_get_type and type_to_string
Date: Fri, 30 Jan 2015 19:46:00 -0000 [thread overview]
Message-ID: <20150130090321.GP5193@adacore.com> (raw)
In-Reply-To: <54CA58D3.2000201@ericsson.com>
> >> gdb/ChangeLog:
> >>
> >> * mi/mi-cmd-var.c (mi_cmd_var_info_type): Free result of
> >> varobj_get_type.
> >> (varobj_update_one): Same.
> >> * varobj.c (update_type_if_necessary): Free curr_type_str and
> >> new_type_str.
> >> (varobj_get_type): Specify in comment that the result needs to be
> >> freed by the caller.
Thank you. This looks good to me, so go ahead and push!
--
Joel
next prev parent reply other threads:[~2015-01-30 9:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 22:48 Simon Marchi
2015-01-29 7:38 ` Joel Brobecker
2015-01-29 16:28 ` Simon Marchi
2015-01-30 19:46 ` Joel Brobecker [this message]
2015-01-30 20:17 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150130090321.GP5193@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).