From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13655 invoked by alias); 30 Jan 2015 09:03:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 13620 invoked by uid 89); 30 Jan 2015 09:03:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 30 Jan 2015 09:03:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id E633F1165C7; Fri, 30 Jan 2015 04:03:24 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id q7CF1pDXMsTj; Fri, 30 Jan 2015 04:03:24 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 8AA66116377; Fri, 30 Jan 2015 04:03:24 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0FF14491CD; Fri, 30 Jan 2015 13:03:21 +0400 (RET) Date: Fri, 30 Jan 2015 19:46:00 -0000 From: Joel Brobecker To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Free results of varobj_get_type and type_to_string Message-ID: <20150130090321.GP5193@adacore.com> References: <1422383618-8215-1-git-send-email-simon.marchi@ericsson.com> <20150129051126.GD5193@adacore.com> <54CA58D3.2000201@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54CA58D3.2000201@ericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-01/txt/msg00797.txt.bz2 > >> gdb/ChangeLog: > >> > >> * mi/mi-cmd-var.c (mi_cmd_var_info_type): Free result of > >> varobj_get_type. > >> (varobj_update_one): Same. > >> * varobj.c (update_type_if_necessary): Free curr_type_str and > >> new_type_str. > >> (varobj_get_type): Specify in comment that the result needs to be > >> freed by the caller. Thank you. This looks good to me, so go ahead and push! -- Joel