From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops
Date: Sat, 31 Jan 2015 20:06:00 -0000 [thread overview]
Message-ID: <20150131032046.GQ5193@adacore.com> (raw)
In-Reply-To: <54CBB44C.8040701@ericsson.com>
> After looking more closely, I think you are right. Originally, I saw that
> install_new_value called value_free on the old value and jumped to the
> conclusion. Actually, value_free is more like a "value_decref", which
> frees the variable if the reference count drops to 0. The call to
> value_free just matches the value_incref that was also done in
> install_new_value when we installed the value. So just calling
> value_of_child doesn't mean that you have to call value_free.
Good :).
> Thanks for the explanation, I didn't know about the memory management of
> values. I'll remove the comment change for value_of_child. Is the rest of
> the patch ok?
Yes, it is. Go ahead and push the version without this particular
comment change.
--
Joel
next prev parent reply other threads:[~2015-01-31 3:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 19:29 [PATCH 1/6] Free results of varobj_get_expression Simon Marchi
2015-01-30 1:56 ` [PATCH 3/6] Set varobj->path_expr in varobj_get_path_expr Simon Marchi
2015-01-30 18:55 ` Joel Brobecker
2015-01-30 22:58 ` Simon Marchi
2015-01-30 3:13 ` [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops Simon Marchi
2015-01-30 8:19 ` Joel Brobecker
2015-01-30 20:10 ` Simon Marchi
2015-01-31 20:06 ` Joel Brobecker [this message]
2015-02-02 18:18 ` Simon Marchi
2015-01-30 3:28 ` [PATCH 6/6] Fix varobj_delete comment Simon Marchi
2015-01-30 17:04 ` Joel Brobecker
2015-01-31 3:20 ` Simon Marchi
2015-01-30 3:33 ` [PATCH 5/6] Mention that create_child takes ownership of the allocated name Simon Marchi
2015-01-30 16:41 ` Joel Brobecker
2015-01-31 1:14 ` Simon Marchi
2015-01-30 3:35 ` [PATCH 4/6] Constify some parameters in the varobj code Simon Marchi
2015-01-30 9:03 ` Joel Brobecker
2015-01-30 22:59 ` Simon Marchi
2015-02-03 16:55 ` Pedro Alves
2015-02-03 18:07 ` Simon Marchi
2015-01-30 3:40 ` [PATCH 1/6] Free results of varobj_get_expression Joel Brobecker
2015-01-30 22:57 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150131032046.GQ5193@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).