public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang S <gang.chen@sunrus.com.cn>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().
Date: Tue, 03 Feb 2015 02:50:00 -0000	[thread overview]
Message-ID: <20150203025001.GJ4525@adacore.com> (raw)
In-Reply-To: <54CFD3F5.5080508@sunrus.com.cn>

Chen,

> >> 2014-01-31  Chen Gang <gang.chen.5i5j@gmail.com>
> >>
> 
> Oh, sorry, the ChangeLog should use 2015-01-31 instead of 2014-01-31 for
> the all related 4 patches. I shall send patch v2 for them.

One important thing to watch out for: I think you may not have realized
that you pushed all 3 patches, whereas only the last one was approved.
So, the first two ones weren't expected to be pushed yet. If you need
help with git on how to push just the patches you want, let us know.
One way, for instance, is to work in a separate branch, and then
cherry-pick on master the patches only at the time where you want
to push them. That's what I do, and prevents this kind of accident
from happening.

In the meantime, since the patches have been pushed, I reviewed them
and they look good to me. So no need to revert. Normally, those are
reviewed by the sim maintainer, so he may have additional comments.

-- 
Joel

  reply	other threads:[~2015-02-03  2:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-31 11:56 Chen Gang S
2015-01-31 18:46 ` Michael Eager
2015-02-02 19:38   ` Chen Gang S
2015-02-03  2:50     ` Joel Brobecker [this message]
2015-02-03  9:58       ` Chen Gang S
2015-02-17 10:34 ` Mike Frysinger
2015-02-17 23:10   ` Chen Gang S
2015-02-18  0:22     ` Mike Frysinger
2015-02-19  0:34       ` Chen Gang S
2015-02-19 15:53         ` Michael Eager
  -- strict thread matches above, loose matches on Subject: below --
2015-01-31  8:59 Chen Gang S
2015-01-28 15:53 Chen Gang S
2015-01-28 20:43 ` Michael Eager
2015-01-29  4:53   ` Chen Gang S
2015-01-29  5:01     ` Michael Eager
2015-01-29  5:11       ` Chen Gang S
2015-02-17 10:36     ` Mike Frysinger
2015-01-29  7:03 ` Joel Brobecker
2015-01-29  7:28   ` Chen Gang S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150203025001.GJ4525@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gang.chen@sunrus.com.cn \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).