From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9209 invoked by alias); 3 Feb 2015 02:50:09 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 9199 invoked by uid 89); 3 Feb 2015 02:50:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Tue, 03 Feb 2015 02:50:07 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 73623116449; Mon, 2 Feb 2015 21:50:05 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id uDfx1wdA6e4f; Mon, 2 Feb 2015 21:50:05 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 84F0F116440; Mon, 2 Feb 2015 21:50:04 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 44FC640EBF; Tue, 3 Feb 2015 06:50:01 +0400 (RET) Date: Tue, 03 Feb 2015 02:50:00 -0000 From: Joel Brobecker To: Chen Gang S Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). Message-ID: <20150203025001.GJ4525@adacore.com> References: <54CC0E99.1070501@sunrus.com.cn> <54CC2C8E.4090308@eagerm.com> <54CFD3F5.5080508@sunrus.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54CFD3F5.5080508@sunrus.com.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00043.txt.bz2 Chen, > >> 2014-01-31 Chen Gang > >> > > Oh, sorry, the ChangeLog should use 2015-01-31 instead of 2014-01-31 for > the all related 4 patches. I shall send patch v2 for them. One important thing to watch out for: I think you may not have realized that you pushed all 3 patches, whereas only the last one was approved. So, the first two ones weren't expected to be pushed yet. If you need help with git on how to push just the patches you want, let us know. One way, for instance, is to work in a separate branch, and then cherry-pick on master the patches only at the time where you want to push them. That's what I do, and prevents this kind of accident from happening. In the meantime, since the patches have been pushed, I reviewed them and they look good to me. So no need to revert. Normally, those are reviewed by the sim maintainer, so he may have additional comments. -- Joel