From: Joel Brobecker <brobecker@adacore.com>
To: Chen Gang S <gang.chen@sunrus.com.cn>
Cc: Doug Evans <xdje42@gmail.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim/mcore/interp.c: Include "unistd.h" standard C header file to avoid compiling warnings.
Date: Sun, 08 Feb 2015 16:00:00 -0000 [thread overview]
Message-ID: <20150208160010.GE4738@adacore.com> (raw)
In-Reply-To: <54D6BE70.2080708@sunrus.com.cn>
> >>>> 2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com>
> >>>>
> >>>> * mcore/interp.c: Include "unistd.h" standard C header file to
> >>>> avoid compiling warnings.
A couple of small procedural nits...
There is a ChangeLog file in sim/mcore, so this is the one that
should be updated, and thus the name of the file in the ChangeLog
entry should not have the "mcore/" part.
Also, the ChangeLog entry should only say "what" has been changed,
not "why". If you feel that the "why" needs to be provided, it should
be provided in the code. In this case, I feel that your revision log
is sufficient.
So, your ChangeLog entry should look like:
2015-02-07 Chen Gang <gang.chen.5i5j@gmail.com>
* interp.c: Include "unistd.h".
--
Joel
next prev parent reply other threads:[~2015-02-08 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 14:12 Chen Gang S
2015-02-07 23:22 ` Doug Evans
2015-02-07 23:54 ` Chen Gang S
2015-02-08 0:35 ` Doug Evans
2015-02-08 1:32 ` Chen Gang S
2015-02-08 16:00 ` Joel Brobecker [this message]
2015-02-09 1:48 ` Chen Gang S
2015-02-09 2:28 ` Joel Brobecker
2015-02-09 10:48 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150208160010.GE4738@adacore.com \
--to=brobecker@adacore.com \
--cc=gang.chen@sunrus.com.cn \
--cc=gdb-patches@sourceware.org \
--cc=xdje42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).