From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32117 invoked by alias); 11 Feb 2015 07:49:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32102 invoked by uid 89); 11 Feb 2015 07:49:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 11 Feb 2015 07:49:03 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 26BF7116776; Wed, 11 Feb 2015 02:49:01 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id N+qI5321jQrs; Wed, 11 Feb 2015 02:49:01 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C48A51163B5; Wed, 11 Feb 2015 02:48:59 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 0B4A640EAD; Wed, 11 Feb 2015 11:48:56 +0400 (RET) Date: Wed, 11 Feb 2015 07:49:00 -0000 From: Joel Brobecker To: David Taylor , Stan Shebs Cc: Stan Shebs , "gdb-patches@sourceware.org" Subject: Re: two agent expression nits (one line each) Message-ID: <20150211074856.GI4738@adacore.com> References: <14583.1410458050@usendtaylorx2l> <547E24E5.8050908@earthlink.net> <20141213134428.GF5457@adacore.com> <23074.1418658035@usendtaylorx2l> <20141220171955.GG12884@adacore.com> <18513.1423000644@usendtaylorx2l> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <18513.1423000644@usendtaylorx2l> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2015-02/txt/msg00291.txt.bz2 Hi Stan, Would you mind reviewing this patch for us, please? If we are going to change a spec, we might as well do it earlier than later and so this could be a good candidate for the 7.9 branch. Thanks! On Tue, Feb 03, 2015 at 04:57:24PM -0500, David Taylor wrote: > Joel Brobecker wrote: > > > Hi David, > > [...] > > > Since you understand what should be done, would you mind sending > > a patch in for Stan to review? > > > > -- > > Joel > > Joel, > > Sorry for the delay. Here's the patch. Also, I haven't forgotten that > I owe you an updated patch for bad structure offsets. And I have some > others in the queue to finish up and post, as well. > > Stan, > > Here's the ChangeLog entries: > > gdb: > > 2015-02-03 David Taylor > > * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > gdb/doc: > > 2015-02-03 David Taylor > > * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > > and patch, as requested by Joel: > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 351ccdd..0118d7d 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor > + > + * common/ax.def (setv): Fix consumed entry in setv DEFOP. > + > 2015-02-02 Joel Brobecker > > * dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker. > diff --git a/gdb/common/ax.def b/gdb/common/ax.def > index 8b27725..27c97cc 100644 > --- a/gdb/common/ax.def > +++ b/gdb/common/ax.def > @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29) > DEFOP (zero_ext, 1, 0, 1, 1, 0x2a) > DEFOP (swap, 0, 0, 2, 2, 0x2b) > DEFOP (getv, 2, 0, 0, 1, 0x2c) > -DEFOP (setv, 2, 0, 0, 1, 0x2d) > +DEFOP (setv, 2, 0, 1, 1, 0x2d) > DEFOP (tracev, 2, 0, 0, 1, 0x2e) > DEFOP (tracenz, 0, 0, 2, 0, 0x2f) > DEFOP (trace16, 2, 0, 1, 1, 0x30) > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > index 9c12d9a..34fee48 100644 > --- a/gdb/doc/ChangeLog > +++ b/gdb/doc/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor > + > + * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > + > 2015-01-31 Gary Benson > Doug Evans > > diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi > index 788de1c..297cd5e 100644 > --- a/gdb/doc/agentexpr.texi > +++ b/gdb/doc/agentexpr.texi > @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a > 16-bit on an unaligned address raises an exception, you should fetch the > register number one byte at a time. > > -@item @code{setv} (0x2d) @var{n}: @result{} @var{v} > +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} > Set trace state variable number @var{n} to the value found on the top > of the stack. The stack is unchanged, so that the value is readily > available if the assignment is part of a larger expression. The -- Joel