From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19538 invoked by alias); 17 Feb 2015 10:34:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19526 invoked by uid 89); 17 Feb 2015 10:34:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Feb 2015 10:34:28 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id 8B25C34066C; Tue, 17 Feb 2015 10:34:25 +0000 (UTC) Date: Tue, 17 Feb 2015 10:34:00 -0000 From: Mike Frysinger To: Chen Gang S Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). Message-ID: <20150217103425.GB544@vapier> Mail-Followup-To: Chen Gang S , gdb-patches@sourceware.org References: <54CC0E99.1070501@sunrus.com.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NDin8bjvE/0mNLFQ" Content-Disposition: inline In-Reply-To: <54CC0E99.1070501@sunrus.com.cn> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00422.txt.bz2 --NDin8bjvE/0mNLFQ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 603 On 31 Jan 2015 07:07, Chen Gang S wrote: > --- a/sim/ChangeLog > +++ b/sim/ChangeLog > @@ -1,5 +1,10 @@ > 2014-01-31 Chen Gang >=20=20 > + * microblaze/interp.c (sim_do_command): Call freeargv() before > + return. this should be in sim/microblaze/ChangeLog instead. it looks like your las= t 4=20 entries in sim/ChangeLog need to get relocated. please do so. while you're there, you should also fix your gentmap.c entry in=20 sim/common/ChangeLog -- only one space after the * is used. as for the actual code, lgtm. thanks for fixing up the various error paths. -mike --NDin8bjvE/0mNLFQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU4xkxAAoJEEFjO5/oN/WBDCEP+QFSX2yy0xAP3HJf8T9+plQ4 4uOOJFX1XoTbCLRaZ7g8ZXM+cCLzhFHxehz2baOzFGxQp/Mjrz8qb2NO/Fm9TjrH D2nC1AJatk+H6u0ZJrzacyw4G4FFuA1U7YmygOocpohRFOlOBnLoMy0YW0NU5y+T o41kJnUd3nSWO79dQKXthI2JNcwFWjUgORnMwuEMEjsxrUC16g0NZaIKadPtIxEU VTxu6vV1S4PwTAkuRLg9rB+ijniBNpK6DCMQpZnFlPCVcFj/wYos+9GiPwiR1HG+ W9nsn9qPsWiShB58W71GZjO3hItgLGuSeW/js9jhDcGF09g9qchxO9EsSyZmf+T7 hshoXfG2UWw0P1wsn0qPupRHxQ85CKM7GkUqC5IZs5V5hgrMCiwfWW8tt5OJ4SQh 1beEDzTk4Wuhjn5lg821cNI0zwf3T2LU8lzEApOOTediTACEUB+Va+Mbe+GtnALH ODCmR16oZ/Gap9ll/wGwVkniG2GD8QZci1tuJ8xN+NCzzD/yViZYK+EA7G0lbC04 q0TGdh/h4Wbp6o6kD4uMn47JmFEVkw+oy3Dfc72t98RBxfE1mW3c6/kZJsDqGGDg GnCDaYp7mRgehC6mJvMPljTK8mdlfzWrDoFa0QiwJ45uGpldQTROiKdbadkVGjNW xFhRT9agGyjjEs7lQX64 =GPGQ -----END PGP SIGNATURE----- --NDin8bjvE/0mNLFQ--