From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4405 invoked by alias); 18 Feb 2015 00:22:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4393 invoked by uid 89); 18 Feb 2015 00:22:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp.gentoo.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 18 Feb 2015 00:22:02 +0000 Received: from vapier (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with SMTP id C856E3406A6; Wed, 18 Feb 2015 00:21:59 +0000 (UTC) Date: Wed, 18 Feb 2015 00:22:00 -0000 From: Mike Frysinger To: Chen Gang S Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). Message-ID: <20150218002200.GQ544@vapier> Mail-Followup-To: Chen Gang S , gdb-patches@sourceware.org References: <54CC0E99.1070501@sunrus.com.cn> <20150217103425.GB544@vapier> <54E3CC2D.40402@sunrus.com.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jsrFa/5v3cIbBmG8" Content-Disposition: inline In-Reply-To: <54E3CC2D.40402@sunrus.com.cn> X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00473.txt.bz2 --jsrFa/5v3cIbBmG8 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1509 On 18 Feb 2015 07:18, Chen Gang S wrote: > On 2/17/15 18:34, Mike Frysinger wrote: > > On 31 Jan 2015 07:07, Chen Gang S wrote: > >> --- a/sim/ChangeLog > >> +++ b/sim/ChangeLog > >> @@ -1,5 +1,10 @@ > >> 2014-01-31 Chen Gang > >>=20=20 > >> + * microblaze/interp.c (sim_do_command): Call freeargv() before > >> + return. > >=20 > > this should be in sim/microblaze/ChangeLog instead. it looks like your= last 4=20 > > entries in sim/ChangeLog need to get relocated. please do so. > >=20 >=20 > Oh, really, I shall change the related comments. >=20 > > while you're there, you should also fix your gentmap.c entry in=20 > > sim/common/ChangeLog -- only one space after the * is used. > >=20 >=20 > Oh, really, I shall change the related comments. >=20 > > as for the actual code, lgtm. thanks for fixing up the various error p= aths. >=20 > That what I should do, since I focus on binutils and gdb. :-) >=20 > And excuse me, I am not quite familiar with the related working flow. > Can I send 1 patch to fix the 2 comments, and "git push" it after it is > reviewed?. generally the sim tree follows the gdb/binutils procedure. i.e. people sho= uld=20 post patches to the list and wait for approval from a relevant maintainer. = we=20 don't generally get strict with the rules as long as you have good intentio= ns=20 and aren't breaking things (like compile failures) :). so don't get too wo= rried=20 and feel free to ask as people don't mind helping guide newbies. -mike --jsrFa/5v3cIbBmG8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU49snAAoJEEFjO5/oN/WBFhIP/0zYqZbVVk3gl5hu0igAt0qr kcFpToqmntj5t27MYYc1E+F/uneXuTugNMvOuMfi4I30Rb0iyjg4qo90yXdH+kK5 nkElXR+kb4NS4ZaxzZlyFaCohsFt9oE2+fwpNHBgPTdiV94gUlfQBw+Ie5ZtXvaM 2ldqo99EGyytKDpZoMpiUmloBDJ2MJRabp1eSMq5OnONcDfybmQI3pTvMQ+QbSNr +8I1DdctKitC/D9EcfdmwLsvnTQfZeyNcMg+a2a75c2QQa9xlJnw0aJQiDQrU/yM uhiyJnkt6UrSrHF32B9QStnpvSaxFPSUipQQDh4bYRnCpc4JyrEyvR55jkwQ96cJ gXkfePG2XB6HjUeque5Sr1EMfRw7SmynUCLWeJhe7k5NNFTtenaP7iXAOzKhs2tt bCtFhREp6dDWSGVQxm4vig8i3QO22tvC8xyMalQK714lRMmJIT3lSYVy3BiqvD8V +A6VFYhlfzEcDspJG1l4s/L3lPSSxeZWoU+XTxjN/B3OINF3ptrMkq1qNeIw7q/G olJe1OkaMCQngsL+eJP938bgFCyJysnbqN9LJ4Su30U48PNOca+OfFPKGaHb6Omn dneFsVLz4hpJbzPtXQNbkdtg9ex9hSOqQdJecNmP6Y9SQEU5PqeHpIs4ZWYIpBCo YS4RVIx7qMFKuEeXk+N2 =ix4H -----END PGP SIGNATURE----- --jsrFa/5v3cIbBmG8--